Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span: Add tests to verify type loader checks for ref-like types #7102

Closed
jkotas opened this issue Dec 8, 2016 · 6 comments
Closed

Span: Add tests to verify type loader checks for ref-like types #7102

jkotas opened this issue Dec 8, 2016 · 6 comments
Assignees
@kouvel
Labels
area-System.Memory test-enhancement Improvements of test source code
Milestone
2.1.0

Comments

@jkotas
Copy link
Member

jkotas commented Dec 8, 2016

  • Span cannot be boxed
  • Span cannot be used as argument of generic instantiations
  • Span cannot be used as type of static fields or non-value type instance fields
@joshfree joshfree changed the title Add tests to verify type loader checks for ref-like types Span: Add tests to verify type loader checks for ref-like types Dec 15, 2016
@gkhanna79 gkhanna79 assigned kouvel and unassigned gkhanna79 Jan 4, 2017
kouvel referenced this issue in kouvel/coreclr Jan 23, 2017
@kouvel
Disallow statics of spans and class instance members of span
7268132 
Functional fix for #8516 to cover some additional cases. IL tests will be coming later in a separate PR.
jkotas referenced this issue in dotnet/coreclr Jan 24, 2017
@kouvel @jkotas
Disallow statics of spans and class instance members of span (#9061)
969cea6 
Functional fix for #8516 to cover some additional cases. IL tests will be coming later in a separate PR.
@ahsonkhan
Copy link
Contributor

@kouvel, any updates on this issue?

@kouvel
Copy link
Member

kouvel commented Apr 5, 2017

I had tested the C# versions of these tests and all is good, just need to convert them to IL tests

@ahsonkhan
Copy link
Contributor

ahsonkhan commented Oct 18, 2017 •
edited
Loading

@kouvel, any updates on this issue?
This is one of the two remaining issues under "VM - Correctness" from https://github.com/dotnet/coreclr/issues/5851#issue-160849016

@kouvel
Copy link
Member

kouvel commented Oct 18, 2017

Nope, haven't had the time to look at my issues

@ahsonkhan
Copy link
Contributor

@kouvel, can you please triage/prioritize this issue. Ty

kouvel referenced this issue in kouvel/coreclr Jan 5, 2018
@kouvel
Add IL tests for cases where Span is not allowed
14398e3 
Fixes https://github.com/dotnet/coreclr/issues/8516
@ahsonkhan
Copy link
Contributor

Fixed in dotnet/coreclr#15745.
Closing.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kouvel kouvel

Labels
area-System.Memory test-enhancement Improvements of test source code
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
5 participants
@ahsonkhan @jkotas @msftgits @gkhanna79 @kouvel