This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Disallow statics of spans and class instance members of span #9061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functional fix for #8516 to cover some additional cases. IL tests will be coming later in a separate PR.
jkotas
reviewed
Jan 23, 2017
| { | ||
| // fIsStatic - By-ref-like types cannot be used for static fields | ||
| // !IsValueClass() - Non-value-classes cannot contain by-ref-like instance fields | ||
| COMPlusThrowHR(COR_E_TYPELOAD); |
There was a problem hiding this comment.
It may be useful to add more descriptive error message for this - I expect that folks are going to hit this until we get the enforcement in the language.
BuildMethodTableThrowException(IDS_XXX);
|
@dotnet-bot test this please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…coreclr#9061) Functional fix for dotnet/coreclr#8516 to cover some additional cases. IL tests will be coming later in a separate PR. Commit migrated from dotnet/coreclr@969cea6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional fix for #8516 to cover some additional cases. IL tests will be coming later in a separate PR.