[ci] Move Windows build and test to VS2019 #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Aug 27, 2019
We've been encountering a handful of issues recently with the Windows machine pool we're using for building and testing. There have been quite a few failures caused by files being locked, or dependencies being out of date or missing. Moving to the VSEng VS2019 Windows pool will hopefully resolve some of these issues. Unfortunately the size of our build dependencies presents an issue when attempting to use the Microsoft hosted Windows VS2019 agents, as our Win job ultimately runs out of space when executing on those VMS. Using the VSEng VS2019 pool will allow us to migrate to VS2019 while avoiding disk space limitations.
pjcollins
force-pushed
the
win-build-test-2019
branch
from
b499114 to
a575ec8
Compare
pjcollins
changed the title
As of commit 8cdda11, `$(JavaSdkDirectory)` will have a default value of the path to the Corretto JDK we install on both Windows and macOS. We should try to use this JDK path for all Android/Java tool invocations which require `$(JAVA_HOME)` to be set.
Versions 2+ of .NET Core are installed into `C:\Program Files\dotnet` rather than `C:\Program Files (x86)\Microsoft Visual Studio\$(Version)`.
|
@dellis1972 @jonathanpeppers This should hopefully be ready to go now. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Common/Builder.cs
Show resolved
Hide resolved
pjcollins
force-pushed
the
win-build-test-2019
branch
from
21e4efe to
69fa843
Compare
jonathanpeppers
approved these changes
Aug 30, 2019
jonpryor
pushed a commit
that referenced
this pull request
Sep 4, 2019
We've been encountering a handful of issues recently with the Windows machine pool we're using for building and testing. There have been quite a few failures caused by files being locked, or dependencies being out of date or missing, or CS8107 errors on the [mono/2019-08 bump PR][0] because source code is using C#7.1 features: external\linker\src\linker\Linker.Steps\MarkStep.cs(2272,19): Error CS8107: Feature 'default literal' is not available in C# 7.0. Please use language version 7.1 or greater. [0]: #3449 Moving to the VSEng VS2019 Windows pool will hopefully resolve some of these issues. Unfortunately the size of our build dependencies presents an issue when attempting to use the Microsoft hosted Windows VS2019 agents, as our Win job ultimately runs out of space when executing on those VMS. Using the VSEng VS2019 pool will allow us to migrate to VS2019 while avoiding disk space limitations. Additionally, as of commit 8cdda11, `$(JavaSdkDirectory)` will have a default value of the path to the Corretto JDK we install on both Windows and macOS. We should try to use this JDK path for all Android/Java tool invocations which require `$(JAVA_HOME)` to be set. Finally, remove the `Builder.MicrosoftNetSdkDirectory` property and related attempts to find the .NET Core SDK path, as `azure-pipelines.yaml` now explicitly installs our required .NET Core SDK version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been encountering a handful of issues recently with the Windows
machine pool we're using for building and testing. There have been quite
a few failures caused by files being locked, or dependencies being out
of date or missing. Moving to the VSEng VS2019 Windows pool will
hopefully resolve some of these issues.
Unfortunately the size of our build dependencies presents an issue when
attempting to use the Microsoft hosted Windows VS2019 agents, as our Win
job ultimately runs out of space when executing on those VMS. Using the
VSEng VS2019 pool will allow us to migrate to VS2019 while avoiding disk
space limitations.
As of commit 8cdda11,
$(JavaSdkDirectory)will have a default valueof the path to the Corretto JDK we install on both Windows and macOS.
We should try to use this JDK path for all Android/Java tool invocations
which require
$(JAVA_HOME)to be set.Also adds a process monitor/killer to our Windows build jobs to attempt
to better monitor, or hopefully prevent, cases of our source directory being
in use by an external process when a job starts.