-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to mono:2019-08 #3449
Merged
Merged
Bump to mono:2019-08 #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep an eye on this one, all our integration documentation is apparently no longer applicable. I hope I updated the right places. |
…n/xamarin-android/pull/3443/files. They may help CI get further
…droid/pull/3443/files. It was under review, so I wanted to see if the other changes made CI work
radekdoulik
added a commit
to dotnet/java-interop
that referenced
this pull request
Aug 13, 2019
This reverts commit 807ed48. This change doesn't play well with XA/master branch, because it uses older cecil version without the API break. I have created mono-2019-08 branch here in Java.Interop for mono/2019-08 specific changes for dotnet/android#3449 integration PR. Changes from mono-2019-08 branch (plus this reverted bump) could be merged to master, once the integration PR is merged to XA.
jonpryor
pushed a commit
that referenced
this pull request
Aug 30, 2019
We've been encountering a handful of issues recently with the Windows machine pool we're using for building and testing. There have been quite a few failures caused by files being locked, or dependencies being out of date or missing, or CS8107 errors on the [mono/2019-08 bump PR][0] because source code is using C#7.1 features: external\linker\src\linker\Linker.Steps\MarkStep.cs(2272,19): Error CS8107: Feature 'default literal' is not available in C# 7.0. Please use language version 7.1 or greater. [0]: #3449 Moving to the VSEng VS2019 Windows pool will hopefully resolve some of these issues. Unfortunately the size of our build dependencies presents an issue when attempting to use the Microsoft hosted Windows VS2019 agents, as our Win job ultimately runs out of space when executing on those VMS. Using the VSEng VS2019 pool will allow us to migrate to VS2019 while avoiding disk space limitations. Additionally, as of commit 8cdda11, `$(JavaSdkDirectory)` will have a default value of the path to the Corretto JDK we install on both Windows and macOS. We should try to use this JDK path for all Android/Java tool invocations which require `$(JAVA_HOME)` to be set. Finally, remove the `Builder.MicrosoftNetSdkDirectory` property and related attempts to find the .NET Core SDK path, as `azure-pipelines.yaml` now explicitly installs our required .NET Core SDK version.
Bump to xamarin/monodroid:master@ae622c Bump to xamarin/monodroid:master@ae622c Bump to xamarin/monodroid:master@ae622c Bump to xamarin/monodroid:master@ae622c Bump to xamarin/monodroid:master@ae622c Bump to xamarin/monodroid:master@ae622c Bump to xamarin/monodroid:master@ae622c Bump to xamarin/monodroid:master@ae622c
jonpryor
pushed a commit
that referenced
this pull request
Sep 4, 2019
We've been encountering a handful of issues recently with the Windows machine pool we're using for building and testing. There have been quite a few failures caused by files being locked, or dependencies being out of date or missing, or CS8107 errors on the [mono/2019-08 bump PR][0] because source code is using C#7.1 features: external\linker\src\linker\Linker.Steps\MarkStep.cs(2272,19): Error CS8107: Feature 'default literal' is not available in C# 7.0. Please use language version 7.1 or greater. [0]: #3449 Moving to the VSEng VS2019 Windows pool will hopefully resolve some of these issues. Unfortunately the size of our build dependencies presents an issue when attempting to use the Microsoft hosted Windows VS2019 agents, as our Win job ultimately runs out of space when executing on those VMS. Using the VSEng VS2019 pool will allow us to migrate to VS2019 while avoiding disk space limitations. Additionally, as of commit 8cdda11, `$(JavaSdkDirectory)` will have a default value of the path to the Corretto JDK we install on both Windows and macOS. We should try to use this JDK path for all Android/Java tool invocations which require `$(JAVA_HOME)` to be set. Finally, remove the `Builder.MicrosoftNetSdkDirectory` property and related attempts to find the .NET Core SDK path, as `azure-pipelines.yaml` now explicitly installs our required .NET Core SDK version.
jonpryor
reviewed
Sep 4, 2019
grendello
approved these changes
Sep 5, 2019
Squash-and-merge commit message:
|
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 6, 2019
Changes: http://github.com/mono/mono/compare/2c3aeaf3780de7392a0d3cbe4dcf86846eb4dffa...29b1ac19c961b959a09097dbc0fe4cd567cc5298 $ git diff --shortstat 2c3aeaf3..29b1ac19 1528 files changed, 45421 insertions(+), 21967 deletions(-) Changes: mono/api-doc-tools@d03e819...5da8127 $ git diff --shortstat d03e8198..5da8127a 1001 files changed, 86168 insertions(+), 11863 deletions(-) Changes: mono/api-snapshot@e09042d...1ca8e82 $ git diff --shortstat e09042da..1ca8e82f 28 files changed, 612 insertions(+), 217 deletions(-) Changes: dotnet/cecil@a6c8f5e...cb6c1ca $ git diff --shortstat a6c8f5e1..cb6c1ca9 13 files changed, 233 insertions(+), 88 deletions(-) Changes: mono/corefx@4806207...470e0e1 $ git diff --shortstat 4806207f...470e0e10 4 files changed, 31 insertions(+), 12 deletions(-) Changes: dotnet/linker@ebe2a1f...1f87de3 $ git diff --shortstat ebe2a1f4...1f87de35 90 files changed, 3219 insertions(+), 1224 deletions(-) Changes: dotnet/java-interop@75b1189...4fd3539 $ git diff --shortstat 75b11891...4fd35393 34 files changed, 448 insertions(+), 52 deletions(-) Upstream-Fixes: https://bugs.winehq.org/show_bug.cgi?id=47561 Upstream-Fixes: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/967582 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25071 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25242 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25632 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25709 Upstream-Fixes: https://github.com/dotnet/corefx/issues/37955 Upstream-Fixes: https://github.com/dotnet/corefx/issues/38455 Upstream-Fixes: mono/mono#7377 Upstream-Fixes: mono/mono#8747 Upstream-Fixes: mono/mono#9621 Upstream-Fixes: mono/mono#9664 Upstream-Fixes: mono/mono#9706 Upstream-Fixes: mono/mono#10201 Upstream-Fixes: mono/mono#10645 Upstream-Fixes: mono/mono#10748 Upstream-Fixes: mono/mono#10848 Upstream-Fixes: mono/mono#12141 Upstream-Fixes: mono/mono#13311 Upstream-Fixes: mono/mono#13408 Upstream-Fixes: mono/mono#13412 Upstream-Fixes: mono/mono#13891 Upstream-Fixes: mono/mono#13923 Upstream-Fixes: mono/mono#13945 Upstream-Fixes: mono/mono#14170 Upstream-Fixes: mono/mono#14214 Upstream-Fixes: mono/mono#14214 Upstream-Fixes: mono/mono#14215 Upstream-Fixes: mono/mono#14243 Upstream-Fixes: mono/mono#14377 Upstream-Fixes: mono/mono#14495 Upstream-Fixes: mono/mono#14555 Upstream-Fixes: mono/mono#14724 Upstream-Fixes: mono/mono#14729 Upstream-Fixes: mono/mono#14772 Upstream-Fixes: mono/mono#14792 Upstream-Fixes: mono/mono#14793 Upstream-Fixes: mono/mono#14809 Upstream-Fixes: mono/mono#14830 Upstream-Fixes: mono/mono#14839 Upstream-Fixes: mono/mono#14841 Upstream-Fixes: mono/mono#14847 Upstream-Fixes: mono/mono#14864 Upstream-Fixes: mono/mono#14871 Upstream-Fixes: mono/mono#14917 Upstream-Fixes: mono/mono#14945 Upstream-Fixes: mono/mono#14946 Upstream-Fixes: mono/mono#14948 Upstream-Fixes: mono/mono#14957 Upstream-Fixes: mono/mono#14959 Upstream-Fixes: mono/mono#14960 Upstream-Fixes: mono/mono#14961 Upstream-Fixes: mono/mono#14963 Upstream-Fixes: mono/mono#14971 Upstream-Fixes: mono/mono#14972 Upstream-Fixes: mono/mono#14975 Upstream-Fixes: mono/mono#15023 Upstream-Fixes: mono/mono#15048 Upstream-Fixes: mono/mono#15058 Upstream-Fixes: mono/mono#15080 Upstream-Fixes: mono/mono#15182 Upstream-Fixes: mono/mono#15188 Upstream-Fixes: mono/mono#15189 Upstream-Fixes: mono/mono#15261 Upstream-Fixes: mono/mono#15262 Upstream-Fixes: mono/mono#15263 Upstream-Fixes: mono/mono#15265 Upstream-Fixes: mono/mono#15268 Upstream-Fixes: mono/mono#15307 Upstream-Fixes: mono/mono#15324 Upstream-Fixes: mono/mono#15329 Upstream-Fixes: mono/mono#15330 Upstream-Fixes: mono/mono#15441 Upstream-Fixes: mono/mono#15446 Upstream-Fixes: mono/mono#15503 Upstream-Fixes: mono/mono#15541 Upstream-Fixes: mono/mono#15551 Upstream-Fixes: mono/mono#15556 Upstream-Fixes: mono/mono#15596 Upstream-Fixes: mono/mono#15691 Upstream-Fixes: mono/mono#15692 Upstream-Fixes: mono/mono#15740 Upstream-Fixes: mono/mono#15751 Upstream-Fixes: mono/mono#15760 Upstream-Fixes: mono/mono#15781 Upstream-Fixes: mono/mono#15794 Upstream-Fixes: mono/mono#15825 Upstream-Fixes: mono/mono#15853 Upstream-Fixes: mono/mono#15878 Upstream-Fixes: mono/mono#15887 Upstream-Fixes: mono/mono#15990 Upstream-Fixes: mono/mono#16032 Upstream-Fixes: mono/mono#16411 Upstream-Fixes: mono/mono#16486 Upstream-Fixes: https://github.com/mono/mono/issues/25709 Upstream-Fixes: https://github.com/mono/mono/issues/38821 Upstream-Fixes: dotnet#3112 Upstream-Fixes: dotnet#3168 Update `build-tools/automation/build.groovy` so that it fully cleans the build tree before starting the build, so that the vestigial mono submodule (removed in 0c9f83b) is *actually* removed from the build tree, so that we don't inadvertently use *ancient* submodule contents.
jonpryor
added a commit
that referenced
this pull request
Sep 7, 2019
Changes: http://github.com/mono/mono/compare/2c3aeaf3780de7392a0d3cbe4dcf86846eb4dffa...29b1ac19c961b959a09097dbc0fe4cd567cc5298 $ git diff --shortstat 2c3aeaf3..29b1ac19 1528 files changed, 45421 insertions(+), 21967 deletions(-) Changes: mono/api-doc-tools@d03e819...5da8127 $ git diff --shortstat d03e8198..5da8127a 1001 files changed, 86168 insertions(+), 11863 deletions(-) Changes: mono/api-snapshot@e09042d...1ca8e82 $ git diff --shortstat e09042da..1ca8e82f 28 files changed, 612 insertions(+), 217 deletions(-) Changes: dotnet/cecil@a6c8f5e...cb6c1ca $ git diff --shortstat a6c8f5e1..cb6c1ca9 13 files changed, 233 insertions(+), 88 deletions(-) Changes: mono/corefx@4806207...470e0e1 $ git diff --shortstat 4806207f...470e0e10 4 files changed, 31 insertions(+), 12 deletions(-) Changes: dotnet/linker@ebe2a1f...1f87de3 $ git diff --shortstat ebe2a1f4...1f87de35 90 files changed, 3219 insertions(+), 1224 deletions(-) Changes: dotnet/java-interop@75b1189...4fd3539 $ git diff --shortstat 75b11891...4fd35393 34 files changed, 448 insertions(+), 52 deletions(-) Fixes: #3112 Fixes: #3168 Context: https://bugs.winehq.org/show_bug.cgi?id=47561 Context: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/967582 Context: https://github.com/dotnet/coreclr/issues/25071 Context: https://github.com/dotnet/coreclr/issues/25242 Context: https://github.com/dotnet/coreclr/issues/25632 Context: https://github.com/dotnet/coreclr/issues/25709 Context: https://github.com/dotnet/corefx/issues/37955 Context: https://github.com/dotnet/corefx/issues/38455 Context: mono/mono#7377 Context: mono/mono#8747 Context: mono/mono#9621 Context: mono/mono#9664 Context: mono/mono#9706 Context: mono/mono#10201 Context: mono/mono#10645 Context: mono/mono#10748 Context: mono/mono#10848 Context: mono/mono#12141 Context: mono/mono#13311 Context: mono/mono#13408 Context: mono/mono#13412 Context: mono/mono#13891 Context: mono/mono#13923 Context: mono/mono#13945 Context: mono/mono#14170 Context: mono/mono#14214 Context: mono/mono#14214 Context: mono/mono#14215 Context: mono/mono#14243 Context: mono/mono#14377 Context: mono/mono#14495 Context: mono/mono#14555 Context: mono/mono#14724 Context: mono/mono#14729 Context: mono/mono#14772 Context: mono/mono#14792 Context: mono/mono#14793 Context: mono/mono#14809 Context: mono/mono#14830 Context: mono/mono#14839 Context: mono/mono#14841 Context: mono/mono#14847 Context: mono/mono#14864 Context: mono/mono#14871 Context: mono/mono#14917 Context: mono/mono#14945 Context: mono/mono#14946 Context: mono/mono#14948 Context: mono/mono#14957 Context: mono/mono#14959 Context: mono/mono#14960 Context: mono/mono#14961 Context: mono/mono#14963 Context: mono/mono#14971 Context: mono/mono#14972 Context: mono/mono#14975 Context: mono/mono#15023 Context: mono/mono#15048 Context: mono/mono#15058 Context: mono/mono#15080 Context: mono/mono#15182 Context: mono/mono#15188 Context: mono/mono#15189 Context: mono/mono#15261 Context: mono/mono#15262 Context: mono/mono#15263 Context: mono/mono#15265 Context: mono/mono#15268 Context: mono/mono#15307 Context: mono/mono#15324 Context: mono/mono#15329 Context: mono/mono#15330 Context: mono/mono#15441 Context: mono/mono#15446 Context: mono/mono#15503 Context: mono/mono#15541 Context: mono/mono#15551 Context: mono/mono#15556 Context: mono/mono#15596 Context: mono/mono#15691 Context: mono/mono#15692 Context: mono/mono#15740 Context: mono/mono#15751 Context: mono/mono#15760 Context: mono/mono#15781 Context: mono/mono#15794 Context: mono/mono#15825 Context: mono/mono#15853 Context: mono/mono#15878 Context: mono/mono#15887 Context: mono/mono#15990 Context: mono/mono#16032 Context: mono/mono#16411 Context: mono/mono#16486 Context: https://github.com/mono/mono/issues/25709 Context: https://github.com/mono/mono/issues/38821 Update `build-tools/automation/build.groovy` so that it fully cleans the build tree before starting the build, so that the vestigial mono submodule (removed in 0c9f83b) is *actually* removed from the build tree, so that we don't inadvertently use *ancient* submodule contents.
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
full-mono-integration-build
For PRs; run a full build (~6-10h for mono bumps), not the faster PR subset (~2h for mono bumps)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.