Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker.DotNet.Models.ImageBuildParameters has missing and extra properties #522

Closed
Emdot opened this issue Jun 13, 2021 · 0 comments · Fixed by #586
Closed

Docker.DotNet.Models.ImageBuildParameters has missing and extra properties #522

Emdot opened this issue Jun 13, 2021 · 0 comments · Fixed by #586

Comments

@Emdot
Copy link
Contributor

Emdot commented Jun 13, 2021

Docker.DotNet version 3.125.0.0

Class Docker.DotNet.Models.ImageBuildParameters is supposed to match the request for Docker API's /build endpoint; however, it doesn't match the current version (v 1.41) or any recent version (I checked back to 1.25). The class is missing some properties and has several extra properties.

Missing:

  • pull
  • outputs

Extra:

  • securityopt
  • ulimits
  • cgroupparent
  • session
  • cpusetmems
  • isolation
  • pullparent
HofmeisterAn added a commit to HofmeisterAn/Docker.DotNet that referenced this issue Sep 6, 2022
@HofmeisterAn
fix(dotnet#522): Remove extra properties from ImageBuildParameters
38f103e
HofmeisterAn added a commit to HofmeisterAn/Docker.DotNet that referenced this issue Sep 6, 2022
@HofmeisterAn
fix(dotnet#522): Remove extra properties from ImageBuildParameters
34589f2
@HofmeisterAn HofmeisterAn mentioned this issue Sep 6, 2022
Merged
galvesribeiro pushed a commit that referenced this issue Sep 18, 2022
@HofmeisterAn
Fix #518, #522 (#586)
27cef85 
* fix(#518): Dispose HttpClient

* fix(#522): Remove extra properties from ImageBuildParameters

* fix: Disable CreateContainerAsync_TimeoutExpires_Fails (not deterministic), await containerLogsTask at the end of the GetContainerLogs_* tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #518, #522 HofmeisterAn/Docker.DotNet
1 participant
@Emdot