Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient no dispose #518

Closed
saber-wang opened this issue May 7, 2021 · 0 comments · Fixed by #586
Closed

HttpClient no dispose #518

saber-wang opened this issue May 7, 2021 · 0 comments · Fixed by #586

Comments

@saber-wang
Copy link

Docker.DotNet/src/Docker.DotNet/DockerClient.cs

Line 450 in e51de97

Configuration.Dispose();

HofmeisterAn added a commit to HofmeisterAn/Docker.DotNet that referenced this issue Sep 6, 2022
@HofmeisterAn
fix(dotnet#518): Dispose HttpClient
ed3c9d7
@HofmeisterAn HofmeisterAn mentioned this issue Sep 6, 2022
Merged
galvesribeiro pushed a commit that referenced this issue Sep 18, 2022
@HofmeisterAn
Fix #518, #522 (#586)
27cef85 
* fix(#518): Dispose HttpClient

* fix(#522): Remove extra properties from ImageBuildParameters

* fix: Disable CreateContainerAsync_TimeoutExpires_Fails (not deterministic), await containerLogsTask at the end of the GetContainerLogs_* tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #518, #522 HofmeisterAn/Docker.DotNet
1 participant
@saber-wang