Ensure new expiration date isn't in the past when applying for a membership extension #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en the request was sent) instead of 16/09 the year after the previous membership ended.
henrikhorluck
approved these changes
Jul 19, 2020
| membership = AllowedUsername.objects.get(username=request.user.ntnu_username) | ||
| new_expiration_date = datetime.date(membership.expiration_date.year + 1, 9, 16) | ||
| # Grant membership until 16th of September this year if the request was sent previous to 1st of July, | ||
| # or until 16th of September next year if the request was sent after 1st of July |
There was a problem hiding this comment.
Note: due to leap-years and such, we are not actually guaranteed for it to last until 16th of September the next year. I do not think this is something that we need to address
There was a problem hiding this comment.
Alright, so should it just specify that the applicant is granted membership for one year?
There was a problem hiding this comment.
No, I think this is fine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set new expiration date to 16/09 this year/next year (depending on when the request was sent) instead of 16/09 the year after the previous membership ended. Fix #1399
What kind of a pull request is this?
Code Checklist
(Possible) Breaking Changes
Description of changes
Changed the way the new expiration date is set when applying for a membership extension
Screenshot(s) if appropriate