Updated membership "fails" for users with membership > 1 year old

[melwil]

Currrently the new expiration date for memberships is determined like this:

new_expiration_date = datetime.date(membership.expiration_date.year + 1, 9, 16)

Source: https://github.com/dotKom/onlineweb4/blob/develop/apps/approval/views.py#L86

If a user has membership that expired in 2014, they will get 2015 as the new date, which is still an expired date.

[OptimusCrime]

Could the new date simply be the current year, or would that fuck something up?

[sklirg]

Me updating my thingy August 2016:
New date:
Septembre 2016.
So yes, it would.

[sklirg]

Fixed in #1513

[OptimusCrime]

Still happens. User had bachelor degree 2012 - 2015, and extended their membership. Membership expiration date was sat to september 2016. Had to send a new request to set the date to 2017.

[plusk]

Me and @oleast took a quick gander at this one, and we think it should just be changing this check to instead go based on 1st of July.