implementing ORD() function
#2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
reviewed
Jan 12, 2024
There was a problem hiding this comment.
ORD changes look great. Looks like the change to return booleans as 1 or 0 instead of true or false just needs a little more massaging to make tests happy again. I think you're right that we should fix that though. Probably worth checking ahead of time for any Dolt tests that break from that, too.
I think the server engine tests have a transform step that convert true to 1, so you might be able to just take that out to get them working now that you fixed the root of the boolean representation problem.
added 2 commits
January 12, 2024 22:50
fulghum
approved these changes
Jan 16, 2024
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
ORD()function in MySQL, which converts a unicode character into its numerical representation.In the case of
STRINGS, only the leftmost unicode character is evaluated.Additionally, this PR fixes the bool -> string coversion to match MySQL.
MySQL Docs: https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_ord
Also fixes: dolthub/dolt#7323