Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
…as table doesn't exist.
go-mysql-server
HASH IN <tuple>
when comparing against collated string typesThis PR changes the
HASH IN
to always use a collation to hash the values in the case that we compare a numerical type against a collated string type.fixes Unexpected result when using Boolean in
IN
dolthub/dolt#7338While debugging a customer issue, I noticed that Dolt/GMS has several details in the field metadata packets that differ from MySQL's behavior. This PR fixes the following differences:
@@max_allowed_packet
should be an unsigned integer typeVitess PR: Detect if a system variable scope was explicitly specified or not dolthub/vitess#302
octet_length()
functionThis PR implements
OCTET_LENGTH()
, which is just a synonym forLENGTH()
MySQL Docs: https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_octet-length
quarter()
functionThis PR adds support for the
QUARTER()
function, which tells the quarter from the provided date.MySQL Docs: https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_quarter
ORD()
functionThis PR adds support for the
ORD()
function in MySQL, which converts a unicode character into its numerical representation.In the case of
STRINGS
, only the leftmost unicode character is evaluated.Additionally, this PR fixes the bool -> string coversion to match MySQL.
MySQL Docs: https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_ord
Also fixes: Unexpected results when comparing with empty string dolthub/dolt#7323
CHAR()
functionThis PR implements most of
CHAR()
functionality.Additionally, this fixes an overflow issue with
UINT32
andUINT64
By default, we display Bit Strings in
utf8mb4
, while you need to useUSING
in MySQL.Without
USING
the bit strings are supposed to show up as hexadecimal values.MySQL Docs: https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_char
Code and tests related to estimating output distributions for joins. Limited to numeric types.
vitess
ALTER USER
statementAdds support for parsing
ALTER USER
statements (MySQL reference). First step towards allowing users to change passwords.Related to: Add "Alter User" and "Set Password" SQL Statements dolthub/dolt#7348
Changes the
VarScope
function so that it returns whether a scope was explicitly specified, or if one has been inferred.This is needed because some tooling (e.g. the official MySQL .NET Connector library) will query system variables (e.g.
SELECT @@max_allowed_packet
) and then will look up the returned value in the result set using the expected column name (@@max_allowed_packet
). Currently, from the way we parse the system variable, this was always returned with the scope present, but to match MySQL's behavior, the column name needs to match the requested name.Related GMS PR: Field response packets MySQL consistency improvements dolthub/go-mysql-server#2266
position()
This PR adds support for
POSITION(<expr1> in <expr2>)
, which is a synoynm forLOCATE(<expr1>, <expr2>);
MySQL Docs: https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_position
char()
syntax handlingIn order to support the charset argument for
CHAR(... using <charset>)
, there has to be special syntax support.Companion PR: implementing
CHAR()
function dolthub/go-mysql-server#2255These are pretty narrowly tailored for postgres prepared statements and long term should probably be placed in either doltgresql or another package. Defining them here is just expedient for experimenting with the new interfaces while they change.
Closed Issues
IN