Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have flush binary logs be noop #2170

Merged
merged 5 commits into from
Nov 30, 2023
Merged

have flush binary logs be noop #2170

merged 5 commits into from
Nov 30, 2023

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Nov 29, 2023

max-hoffman
max-hoffman approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, drop in the bucket of the range of MySQL FLUSH statements though https://dev.mysql.com/doc/refman/8.0/en/flush.html

@jycor jycor merged commit 64f9e44 into main Nov 30, 2023
@jycor jycor deleted the james/noop branch November 30, 2023 23:07
@BrewTestBot BrewTestBot mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support flush binary logs
2 participants
@jycor @max-hoffman