Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support flush binary logs #7055

Closed
timsehn opened this issue Nov 27, 2023 · 0 comments · Fixed by dolthub/go-mysql-server#2170
Closed

Support flush binary logs #7055

timsehn opened this issue Nov 27, 2023 · 0 comments · Fixed by dolthub/go-mysql-server#2170
Labels
correctness We don't return the same result as MySQL enhancement New feature or request

Comments

@timsehn
Copy link
Contributor

timsehn commented Nov 27, 2023

This dump file has this line.

flush /*!50503 binary */ logs;

that fails in Dolt:

ERROR 1105 (HY000) at line 110: binary logs not supported

I deleted the line but maybe we should parse it as a no-op?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
correctness We don't return the same result as MySQL enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

have flush binary logs be noop dolthub/go-mysql-server
1 participant
@timsehn