buildControl: set default values for Closure languageIn/languageOut #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Google Closure Compiler has a default language output setting that may change by release. v20170806 changed the default output language to ECMASCRIPT5. This PR adds a default value of 'NO_TRANSPILE' if the build tool is configured to use the Google Closure Compiler.
dylans
approved these changes
Sep 14, 2020
msssk
changed the title
This was referenced Sep 14, 2020
dasa
reviewed
Sep 28, 2020
| bc.optimizeOptions = bc.optimizeOptions || {}; | ||
| // ECMASCRIPT_2017 is necessary to avoid throwing errors on block-scoped functions | ||
| // https://github.com/google/closure-compiler/issues/3189 | ||
| bc.optimizeOptions.languageIn = bc.optimizeOptions.languageIn || 'ECMASCRIPT_2017'; |
There was a problem hiding this comment.
Should this be ECMASCRIPT_2019 to match the stable version here?
https://github.com/google/closure-compiler/blob/v20200112/src/com/google/javascript/jscomp/CompilerOptions.java#L3217
There was a problem hiding this comment.
Another option would be to upgrade Closure to v20201006 and use ECMASCRIPT_2020: https://github.com/google/closure-compiler/wiki/Releases#october-6-2020-v20201006
dylans
pushed a commit
that referenced
this pull request
Mar 20, 2021
) * buildControl: set default languageOut for Closure to 'NO_TRANSPILE' The Google Closure Compiler has a default language output setting that may change by release. v20170806 changed the default output language to ECMASCRIPT5. This PR adds a default value of 'NO_TRANSPILE' if the build tool is configured to use the Google Closure Compiler. * Set default languageIn/languageOut to ECMASCRIPT3 to maintain previous behavior * built tool: set default languageIn to ES2017 (cherry picked from commit 71f486a)
dylans
pushed a commit
that referenced
this pull request
Mar 20, 2021
) * buildControl: set default languageOut for Closure to 'NO_TRANSPILE' The Google Closure Compiler has a default language output setting that may change by release. v20170806 changed the default output language to ECMASCRIPT5. This PR adds a default value of 'NO_TRANSPILE' if the build tool is configured to use the Google Closure Compiler. * Set default languageIn/languageOut to ECMASCRIPT3 to maintain previous behavior * built tool: set default languageIn to ES2017 (cherry picked from commit 71f486a)
dylans
pushed a commit
that referenced
this pull request
Mar 20, 2021
) * buildControl: set default languageOut for Closure to 'NO_TRANSPILE' The Google Closure Compiler has a default language output setting that may change by release. v20170806 changed the default output language to ECMASCRIPT5. This PR adds a default value of 'NO_TRANSPILE' if the build tool is configured to use the Google Closure Compiler. * Set default languageIn/languageOut to ECMASCRIPT3 to maintain previous behavior * built tool: set default languageIn to ES2017 (cherry picked from commit 71f486a)
dylans
pushed a commit
that referenced
this pull request
Mar 20, 2021
) * buildControl: set default languageOut for Closure to 'NO_TRANSPILE' The Google Closure Compiler has a default language output setting that may change by release. v20170806 changed the default output language to ECMASCRIPT5. This PR adds a default value of 'NO_TRANSPILE' if the build tool is configured to use the Google Closure Compiler. * Set default languageIn/languageOut to ECMASCRIPT3 to maintain previous behavior * built tool: set default languageIn to ES2017 (cherry picked from commit 71f486a)
dylans
pushed a commit
that referenced
this pull request
Mar 20, 2021
) * buildControl: set default languageOut for Closure to 'NO_TRANSPILE' The Google Closure Compiler has a default language output setting that may change by release. v20170806 changed the default output language to ECMASCRIPT5. This PR adds a default value of 'NO_TRANSPILE' if the build tool is configured to use the Google Closure Compiler. * Set default languageIn/languageOut to ECMASCRIPT3 to maintain previous behavior * built tool: set default languageIn to ES2017 (cherry picked from commit 71f486a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Closure Compiler has a default language output setting that may change by release. v20170806 changed the default output language to ECMASCRIPT5.
This PR adds a default values for
languageIn(ECMASCRIPT_2017) andlanguageOut(ECMASCRIPT3) if the build tool is configured to use the Google Closure Compiler. These can be overridden inoptimizeOptionsin the build profile.ECMASCRIPT_2017 is used for
languageInto allow existing code to continue working. With the addition of block scope in ES6 the Google Closure Compiler treats block-scoped functions as errors in pre-ES6 code.Fixes #81