Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change block-scoped functions to named function expressions #187

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

msssk
Copy link
Contributor

@msssk msssk commented Sep 14, 2020

With the addition of block scope to ES6 it has become impractical for tools like Google Closure Compiler to handle block-scoped functions in pre-ES6 code and they are flagged as errors.

This PR ensures that dijit can still be built if the build profile sets optimizeOptions.languageIn to 'ECMASCRIPT3' with versions of Google Closure Compiler that support ES6. See dojo/util#83

With the addition of block scope to ES6 it has become impractical for tools
like Google Closure Compiler to handle block-scoped functions in pre-ES6 code
and they are flagged as errors.
google/closure-compiler#3189
@msssk msssk merged commit 7841313 into dojo:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant