Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Improve selection utilites #82

Merged
merged 5 commits into from
Nov 14, 2017
Merged

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented Nov 13, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:
Adds replaceChildByKey, replaceChildPropertiesByKey, and assignChildPropertyByKey functions to support/d.ts. This also refactors some of the logic in support/d.ts to reuse the same logic for finding nodes in multiple places.
Resolves #9, #28

@maier49 maier49 requested a review from kitsonk November 13, 2017 23:05
@codecov
Copy link

codecov bot commented Nov 13, 2017

Codecov Report

Merging #82 into master will increase coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage    98.5%   99.02%   +0.52%     
==========================================
  Files           9        9              
  Lines         601      618      +17     
  Branches      164      173       +9     
==========================================
+ Hits          592      612      +20     
+ Misses          1        0       -1     
+ Partials        8        6       -2
Impacted Files Coverage Δ
src/support/d.ts 100% <100%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a121209...5ed3322. Read the comment docs.

@kitsonk
Copy link
Member

kitsonk commented Nov 14, 2017

README Updates?

Copy link
Member

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you.

@maier49 maier49 merged commit 77e80ac into dojo:master Nov 14, 2017
@maier49 maier49 deleted the improve-selection-utilites branch November 14, 2017 18:23
maier49 added a commit to maier49/test-extras that referenced this pull request Nov 15, 2017
@dylans dylans added this to the beta.4 milestone Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants