Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Updated an expected render by key #9

Closed
kitsonk opened this issue Apr 10, 2017 · 1 comment
Closed

Updated an expected render by key #9

kitsonk opened this issue Apr 10, 2017 · 1 comment
Assignees
Milestone

Comments

@kitsonk
Copy link
Member

kitsonk commented Apr 10, 2017

Enhancement

We have helper functions that allow a developer to update parts of a virtual DOM (e.g. replaceChild, assignChildProperties) which allow selection of the parts of the virtual DOM by index. We should allow the same functionality by specifying a key. For example, you should be able to do:

replaceByKey(node, 'key', replacementNode);
replacePropertiesByKey(node, 'key', replacementProperties);
replaceChildrenByKey(node, 'key', replacementChildren);
assignPropertiesByKey(node, 'key', properties);
@dylans dylans added this to the 2017.04 milestone Apr 10, 2017
@kitsonk
Copy link
Member Author

kitsonk commented Apr 13, 2017

We should also consider just plain selection by key and index, allowing the return on a child node for further inspection/assertion.

@kitsonk kitsonk self-assigned this Apr 24, 2017
kitsonk added a commit that referenced this issue May 1, 2017
@dylans dylans modified the milestones: 2017.05, 2017.04 May 2, 2017
@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
@dylans dylans modified the milestones: 2017.06, 2017.07 Jul 4, 2017
@dylans dylans modified the milestones: 2017.07, 2017.09 Jul 29, 2017
@kitsonk kitsonk modified the milestones: 2017.09, 2017.11 Oct 6, 2017
@kitsonk kitsonk added the rc label Oct 6, 2017
@maier49 maier49 self-assigned this Nov 10, 2017
@maier49 maier49 mentioned this issue Nov 13, 2017
3 tasks
maier49 added a commit that referenced this issue Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants