Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Add checks for window global assignments in loadJsdom #11

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

kitsonk
Copy link
Member

@kitsonk kitsonk commented Apr 12, 2017

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

This is just to help ensure that loadJsdom load the DOM in a way that is likely to be the most widely supported by code.

@codecov
Copy link

codecov bot commented Apr 12, 2017

Codecov Report

Merging #11 into master will decrease coverage by 1.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   98.57%   96.96%   -1.61%     
==========================================
  Files           8        8              
  Lines         560      560              
  Branches      126      126              
==========================================
- Hits          552      543       -9     
- Misses          4        9       +5     
- Partials        4        8       +4
Impacted Files Coverage Δ
src/support/assertRender.ts 91.42% <0%> (-8.58%) ⬇️
src/harness.ts 95.5% <0%> (-3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc219c...87abd9c. Read the comment docs.

@kitsonk
Copy link
Member Author

kitsonk commented Apr 12, 2017

Tests for #10 which really isn't an issue.

codecov is crazy... this won't reduce the coverage of the by merging, because none of the functional code is being touched... 😢

@dylans dylans added this to the 2017.04 milestone Apr 12, 2017
@kitsonk kitsonk merged commit c846f15 into master Apr 13, 2017
@kitsonk kitsonk deleted the issue-10-window-window branch May 5, 2017 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants