Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

window.window should work under JSDom #10

Closed
kitsonk opened this issue Apr 12, 2017 · 1 comment
Closed

window.window should work under JSDom #10

kitsonk opened this issue Apr 12, 2017 · 1 comment
Assignees
@kitsonk
Labels
bug
Milestone
2017.04

Comments

@kitsonk
Copy link
Member

kitsonk commented Apr 12, 2017

Bug

The window when jsdom is loaded should contain a reference to itself under the window.window property. This is to help ensure that when code tries to grab a reference to the global scope, that it will be able to have a reference to the window without assuming it is actually the global scope.
@kitsonk kitsonk added the bug label Apr 12, 2017
@kitsonk kitsonk self-assigned this Apr 12, 2017
@kitsonk kitsonk mentioned this issue Apr 12, 2017
Merged
3 tasks
@kitsonk
Copy link
Member Author

kitsonk commented Apr 12, 2017

This doesn't appear to be an issue in reality, but added PR #11 to ensure this works as expected.

@kitsonk kitsonk closed this as completed Apr 12, 2017
@dylans dylans added this to the 2017.04 milestone Apr 12, 2017
kitsonk added a commit that referenced this issue Apr 13, 2017
@kitsonk
Add checks for window global assignments in loadJsdom (#11)
c846f15 
Fixes #10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kitsonk kitsonk

Labels
bug
Projects
None yet
Milestone
2017.04
Development

No branches or pull requests
2 participants
@dylans @kitsonk