Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating environment, grib2 writing support, version #38

Merged
merged 19 commits into from
Sep 30, 2021
Merged

Conversation

djgagne
Copy link
Owner

@djgagne djgagne commented Sep 22, 2021

Because ncepgrib2 was separated from pygrib and then deprecated, I have added support for the new grib2io package, which mostly replicates the ncepgrib2 functionality. I haven't tested it yet on actual forecast data, which we need to do before merging.

@djgagne djgagne requested review from alburke and removed request for alburke September 22, 2021 16:19
Copy link
Collaborator

@charlie-becker charlie-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just made one potential suggestion to consolidate install process.

@djgagne djgagne merged commit 57d1051 into master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants