Empty value django 1.11 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkonrath
force-pushed
the
empty-value-django-1.11
branch
3 times, most recently
from
ac82d31 to
bcade36
Compare
benkonrath
force-pushed
the
empty-value-django-1.11
branch
from
bcade36 to
7d7356d
Compare
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
==========================================
+ Coverage 96.01% 96.29% +0.28%
==========================================
Files 150 151 +1
Lines 4167 4214 +47
Branches 567 579 +12
==========================================
+ Hits 4001 4058 +57
+ Misses 107 97 -10
Partials 59 59
Continue to review full report at Codecov.
|
|
This is ready to go but I'd like to get some feedback if somebody has some time to double it. I'm planning to cherry pick 7d7356d into the 1.5.x branch and make a 1.5.2 release |
|
Looks good to me, thanks! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
empty_valuekwarg that was added toforms.CharFieldin Django 1.11.On Django < 1.11, form fields that inherit from
forms.CharFieldset an empty string for values that are inself.empty_values. On Django >= 1.11, form fields that inherit fromforms.CharFieldsetself.empty_valuefor values that are inself.empty_values. This means all of the fields now support theempty_valuekwarg even when it'sNone.The downside to this change is that form fields that inherit from
forms.CharFieldwill need to use theEmptyValueCompatMixinuntil we drop support for Django < 1.11.Related #294 #295
Closes #297