-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #294 #295
Fixes #294 #295
Conversation
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 96.01% 96.01% +<.01%
==========================================
Files 150 150
Lines 4165 4167 +2
Branches 566 567 +1
==========================================
+ Hits 3999 4001 +2
Misses 107 107
Partials 59 59
Continue to review full report at Codecov.
|
Thanks for the fix. Can you add a failing test that's fixed by this change? It should be enough to test the form field with |
…s (updated to support testing version of django < 1.11
@benkonrath Added a test. It's a little hackish because Django < 1.11 don't support passing in Is there anything else you need to get this pulled in? |
Seems like a good solution. I'll make a 1.5.1 release with this fix soon. |
USZipCodeField with null=True and Blank=Ture caused a crash on Django 1.11. Fixes #294
Fixes form validation crash for USZipCodeField when field is null=True, blank=True. See #294
Do not call strip on a None.
All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.
Adjust your imports to a standard form by running this command: