Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables fetching scala library sources #7464

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Enables fetching scala library sources #7464

merged 2 commits into from
Sep 23, 2020

Conversation

nmarton-da
Copy link
Contributor

@nmarton-da nmarton-da commented Sep 23, 2020 •
edited
Loading

Enables fetch_sources flag for fetching scala sources.
These sources can be used for manual linking scala library if sources are not resolved otherwise.
Motivation: bazelbuild/rules_scala#908

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@nmarton-da nmarton-da requested review from cocreature and a user September 23, 2020 10:24
cocreature
cocreature approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very sensible, thank you @nmarton-da!

@cocreature
Copy link
Contributor

Looks like you need to reformat, run ./fmt.sh or ./fmt.sh --diff if you need something faster.

@nmarton-da nmarton-da force-pushed the build/fetch-scala-sources branch from 50d31ac to 5f79713 Compare September 23, 2020 10:31
@nmarton-da
Copy link
Contributor Author

Looks like you need to reformat, run ./fmt.sh or ./fmt.sh --diff if you need something faster.

yes, just figured, ran that 👍

@ghost
Copy link

ghost commented Sep 23, 2020

If this doesn't work automatically, can you add some information on how to get it working in BAZEL-JVM.md?

@nmarton-da nmarton-da force-pushed the build/fetch-scala-sources branch from 5f79713 to 288affe Compare September 23, 2020 13:27
ghost
ghost reviewed Sep 23, 2020
View reviewed changes
BAZEL.md Outdated Show resolved Hide resolved
BAZEL.md Outdated Show resolved Hide resolved
BAZEL.md Outdated Show resolved Hide resolved
@nmarton-da
Enables fetching scala library sources
a9a5d48 
Enables fetch_sources flag for fetching scala sources.
These sources can be used for manual linking scala library if sources are not resolved otherwise

CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da nmarton-da force-pushed the build/fetch-scala-sources branch from 288affe to a9a5d48 Compare September 23, 2020 13:34
@mergify mergify bot merged commit 071f604 into master Sep 23, 2020
@mergify mergify bot deleted the build/fetch-scala-sources branch September 23, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmarton-da @cocreature