Fetching scala library sources bazel-deps with rules_scala

[tian000]

When I use bazel deps in my repository, it puts the scala standard library under external which means intelliJ doesn't know where to find the sources for it. Is there a way to set up scala_repositories so that intelliJ attaches the sources correctly?

[tian000]

The workaround I currently have is to propagate a new parameter fetch_sources from scala_maven_import_external up to scala_repositories which allows me to specify scala_repositories(fetch_sources = True). This causes the source jar file to be downloaded, and I can manually select it from this directory:

[ittaiz]

Do you want to send a PR so we can see how this change looks? It sounds like a knob worth adding. We (Wix) use our own scala_repositories which uses its own scala_maven_import_external so we indeed don’t see this problem

On Sat, 28 Dec 2019 at 3:36 Napas (Tian) Udomsak ***@***.***> wrote: The workaround I currently have is to propagate a new parameter fetch_sources from scala_maven_import_external up to scala_repositories which allows me to specify scala_repositories(fetch_sources = True). This causes the source jar file to be downloaded, and I can manually select it from this directory: [image: image] <https://user-images.githubusercontent.com/14320466/71537327-74fe4000-2955-11ea-8a2c-e236ffde56b9.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#908?email_source=notifications&email_token=AAKQQF5HXQZTCTSJVVWEOUDQ22UQ7A5CNFSM4KAEQJGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHX7JKY#issuecomment-569373867>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKQQF64KZQ2K2DGUXQHWBTQ22UQ7ANCNFSM4KAEQJGA> .

-- *Ittai Zeidman* 40 Hanamal street, Tel Aviv, Israel <http://www.wix.com>

[olib963]

This would be a nice feature as it would also allow for downloading of sources for scalatest without having to implement your own scala_repositories.

[tian000]

@ittaiz What is the protocol on closing issues. Should I close this issue?

[ittaiz]

Hi,
Thanks for following up on this.
The protocol is actually for the PR to mention that it fixes this and so the issue would have been closed.
I missed the fact that the PR mentioned the issue but didn’t say it fixed it.
Thanks!