feat(ErrorSummary): split .Item into two components, add asChild support
#3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4376ad3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Barsnes
changed the title
.Item into two components.Item into two components
Barsnes
changed the title
.Item into two components.Item into two components, add asChild support
mimarz
pushed a commit
that referenced
this pull request
Jan 28, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @digdir/[email protected] ### Minor Changes - Rename config option from `--json` to `--config` ([#3012](#3012)) ### Patch Changes - Create & build tokens correctly if support-color is missing ([#3035](#3035)) - Removed predefined `accent` variables added during `tokens build`. Use `data-color` or generated named color variables instead. ([#3041](#3041)) ## @digdir/[email protected] ### Minor Changes - ✨ New experimental component; **Suggestion** ([#3032](#3032)) ### Patch Changes - **Chip**: Make radio and checkbox smaller ([#3039](#3039)) - **ToggleGroup**: Change height to match other form elements ([#3055](#3055)) - Chip: avoid reassigning custom properties ([#3019](#3019)) - **Tabs**: Add overflow-x scroll to tablist ([#3030](#3030)) - **Table**: Use `border-top` in `tbody` ensure prettier tables when no `thead` ([#3020](#3020)) - **Tag**: Set `height` in case it is used in `display: flex` ([#3020](#3020)) - `ds-input` will now by default fill width. ([#3020](#3020)) - **Field**: Move `align-items: start` from `.ds-field` to `align-self: start` on `.ds-input` for easier styling ([#3020](#3020)) ## @digdir/[email protected] ### Minor Changes - ✨ New experimental component; **Suggestion** ([#3032](#3032)) - **ErrorSummary**: Split `.Item` into two components ([#3040](#3040)) - `ErrorSummary.Item` renders a `li` - `ErrorSummary.Link` renders the link - Upgrade to React 19 and other related dependencies ([#2964](#2964)) - **Checkbox**: Rename `validation` to `error` ([#3038](#3038)) - **Radio**: Rename `validation` to `error` ([#3038](#3038)) ### Patch Changes - **ErrorSummary**: Add support for `asChild` ([#3040](#3040)) - fix: Use correct DOM property for Popover API when used in React 19 ([#3010](#3010)) ## @digdir/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mimarz
pushed a commit
that referenced
this pull request
Feb 21, 2025
mimarz
pushed a commit
that referenced
this pull request
Feb 21, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @digdir/designsystemet@1.0.0-next.48 ### Minor Changes - Rename config option from `--json` to `--config` ([#3012](#3012)) ### Patch Changes - Create & build tokens correctly if support-color is missing ([#3035](#3035)) - Removed predefined `accent` variables added during `tokens build`. Use `data-color` or generated named color variables instead. ([#3041](#3041)) ## @digdir/[email protected] ### Minor Changes - ✨ New experimental component; **Suggestion** ([#3032](#3032)) ### Patch Changes - **Chip**: Make radio and checkbox smaller ([#3039](#3039)) - **ToggleGroup**: Change height to match other form elements ([#3055](#3055)) - Chip: avoid reassigning custom properties ([#3019](#3019)) - **Tabs**: Add overflow-x scroll to tablist ([#3030](#3030)) - **Table**: Use `border-top` in `tbody` ensure prettier tables when no `thead` ([#3020](#3020)) - **Tag**: Set `height` in case it is used in `display: flex` ([#3020](#3020)) - `ds-input` will now by default fill width. ([#3020](#3020)) - **Field**: Move `align-items: start` from `.ds-field` to `align-self: start` on `.ds-input` for easier styling ([#3020](#3020)) ## @digdir/[email protected] ### Minor Changes - ✨ New experimental component; **Suggestion** ([#3032](#3032)) - **ErrorSummary**: Split `.Item` into two components ([#3040](#3040)) - `ErrorSummary.Item` renders a `li` - `ErrorSummary.Link` renders the link - Upgrade to React 19 and other related dependencies ([#2964](#2964)) - **Checkbox**: Rename `validation` to `error` ([#3038](#3038)) - **Radio**: Rename `validation` to `error` ([#3038](#3038)) ### Patch Changes - **ErrorSummary**: Add support for `asChild` ([#3040](#3040)) - fix: Use correct DOM property for Popover API when used in React 19 ([#3010](#3010)) ## @digdir/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.