Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Chip): make radio and checbox smaller #3039

Merged
merged 4 commits into from
Jan 23, 2025
Merged

style(Chip): make radio and checbox smaller #3039

merged 4 commits into from
Jan 23, 2025

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Jan 22, 2025

resolves #3031

@Barsnes Barsnes marked this pull request as ready for review January 22, 2025 09:37
Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 2882ece

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-css Patch
@digdir/designsystemet Patch
@digdir/designsystemet-theme Patch
@digdir/designsystemet-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Preview deployments for this pull request:

Storybook - 22. Jan 2025 - 14:27

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.48% 2958 / 5531
🔵 Statements 53.48% 2958 / 5531
🔵 Functions 85.71% 180 / 210
🔵 Branches 76.69% 520 / 678
File CoverageNo changed files found.
Generated in workflow #1747 for commit 2882ece by the Vitest Coverage Report Action

@mrosvik
Copy link
Member

mrosvik commented Jan 22, 2025

LGTM! 🥳

@Barsnes Barsnes merged commit 6ba03fe into next Jan 23, 2025
10 checks passed
@Barsnes Barsnes deleted the chip/size-inp branch January 23, 2025 07:15
mimarz pushed a commit that referenced this pull request Jan 28, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/[email protected]

### Minor Changes

- Rename config option from `--json` to `--config`
([#3012](#3012))

### Patch Changes

- Create & build tokens correctly if support-color is missing
([#3035](#3035))

- Removed predefined `accent` variables added during `tokens build`. Use
`data-color` or generated named color variables instead.
([#3041](#3041))

## @digdir/[email protected]

### Minor Changes

- ✨ New experimental component; **Suggestion**
([#3032](#3032))

### Patch Changes

- **Chip**: Make radio and checkbox smaller
([#3039](#3039))

- **ToggleGroup**: Change height to match other form elements
([#3055](#3055))

- Chip: avoid reassigning custom properties
([#3019](#3019))

- **Tabs**: Add overflow-x scroll to tablist
([#3030](#3030))

- **Table**: Use `border-top` in `tbody` ensure prettier tables when no
`thead` ([#3020](#3020))

- **Tag**: Set `height` in case it is used in `display: flex`
([#3020](#3020))

- `ds-input` will now by default fill width.
([#3020](#3020))

- **Field**: Move `align-items: start` from `.ds-field` to `align-self:
start` on `.ds-input` for easier styling
([#3020](#3020))

## @digdir/[email protected]

### Minor Changes

- ✨ New experimental component; **Suggestion**
([#3032](#3032))

- **ErrorSummary**: Split `.Item` into two components
([#3040](#3040))

    -   `ErrorSummary.Item` renders a `li`
    -   `ErrorSummary.Link` renders the link

- Upgrade to React 19 and other related dependencies
([#2964](#2964))

- **Checkbox**: Rename `validation` to `error`
([#3038](#3038))

- **Radio**: Rename `validation` to `error`
([#3038](#3038))

### Patch Changes

- **ErrorSummary**: Add support for `asChild`
([#3040](#3040))

- fix: Use correct DOM property for Popover API when used in React 19
([#3010](#3010))

## @digdir/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mimarz pushed a commit that referenced this pull request Feb 21, 2025
mimarz pushed a commit that referenced this pull request Feb 21, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/designsystemet@1.0.0-next.48

### Minor Changes

- Rename config option from `--json` to `--config`
([#3012](#3012))

### Patch Changes

- Create & build tokens correctly if support-color is missing
([#3035](#3035))

- Removed predefined `accent` variables added during `tokens build`. Use
`data-color` or generated named color variables instead.
([#3041](#3041))

## @digdir/[email protected]

### Minor Changes

- ✨ New experimental component; **Suggestion**
([#3032](#3032))

### Patch Changes

- **Chip**: Make radio and checkbox smaller
([#3039](#3039))

- **ToggleGroup**: Change height to match other form elements
([#3055](#3055))

- Chip: avoid reassigning custom properties
([#3019](#3019))

- **Tabs**: Add overflow-x scroll to tablist
([#3030](#3030))

- **Table**: Use `border-top` in `tbody` ensure prettier tables when no
`thead` ([#3020](#3020))

- **Tag**: Set `height` in case it is used in `display: flex`
([#3020](#3020))

- `ds-input` will now by default fill width.
([#3020](#3020))

- **Field**: Move `align-items: start` from `.ds-field` to `align-self:
start` on `.ds-input` for easier styling
([#3020](#3020))

## @digdir/[email protected]

### Minor Changes

- ✨ New experimental component; **Suggestion**
([#3032](#3032))

- **ErrorSummary**: Split `.Item` into two components
([#3040](#3040))

    -   `ErrorSummary.Item` renders a `li`
    -   `ErrorSummary.Link` renders the link

- Upgrade to React 19 and other related dependencies
([#2964](#2964))

- **Checkbox**: Rename `validation` to `error`
([#3038](#3038))

- **Radio**: Rename `validation` to `error`
([#3038](#3038))

### Patch Changes

- **ErrorSummary**: Add support for `asChild`
([#3040](#3040))

- fix: Use correct DOM property for Popover API when used in React 19
([#3010](#3010))

## @digdir/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual inconsistency in Chip between code and Figma
3 participants