-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved to-directory-tree #2437
Improved to-directory-tree #2437
Conversation
If this one gets merged, I also suggest we add the types of the issue description of #2436 to the Dhall prelude. |
Not sure what happened here: Hydra failed very early and I have no clue what went wrong... |
Just an instance of #2313. I've restarted the build. |
@sjakobi It failed again. How can I trigger a re-run of the job? |
95087fa
to
d712f3a
Compare
Ok, this is blocked by #2313 for now 😞 |
e719b27
to
3953d23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few comments
Also, would it be possible to create a small Dhall package within this repository for working with the new tree type?
@Gabriella439 I added a commented example to the examples directory of the dhall package. I also think that adding the used types and some useful functions/constants to the Dhall Prelude; What do you think? |
Oh yeah, you can try to add it to the Prelude. At first I was a bit hesitant to add a type that is a bit specific to the Haskell implementation, but we actually already do that in at least one other place in the Prelude, which |
* Added a new command line flag --allow-path-separators for the to-directory-tree command. This flag controls whether path separators in names are allowed. In that case we also create all parent directories of a file. * Added a new way building directory trees using a fixpoint approach. This method allows one to set the user, group and permissions on some OS. * Added unix-compat as a new dependency of the dhall package
Also fixed a minor bug in `Dhall.DirectoryTree.hasMode`.
Also added FromDhall instance for Identity.
Also updated Haddocks of Dhall.DirectoryTree.
Co-authored-by: Gabriella Gonzalez <[email protected]>
Co-authored-by: Gabriella Gonzalez <[email protected]>
ff88ae9
to
faf01b0
Compare
to-directory-tree command. This flag controls whether path separators
in names are allowed. In that case we also create all parent
directories of a file.
Using it allows one to set the user, group and permissions (for some OS).
The values accepted need to have the type given in the issue description of Allow users to set ownership and permissions in to-directory-tree #2436 .
FromDhall
instance forIdentity
Fixes #2436
Fixes #1633