Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows CI failure in Dhall.DirectoryTree #2452

Closed
sjakobi opened this issue Sep 28, 2022 · 4 comments · Fixed by #2455
Closed

Windows CI failure in Dhall.DirectoryTree #2452

sjakobi opened this issue Sep 28, 2022 · 4 comments · Fixed by #2455
Assignees
@mmhat
Labels
CI Continuous Integration

Comments

@sjakobi
Copy link
Collaborator

sjakobi commented Sep 28, 2022

See https://github.com/dhall-lang/dhall-haskell/actions/runs/3138921448/jobs/5098786985#step:5:3517.

This seems related to #2437. Could you possibly take a look, @mmhat?
@sjakobi sjakobi added the CI Continuous Integration label Sep 28, 2022
@sjakobi sjakobi mentioned this issue Sep 28, 2022
Merged
@mmhat
Copy link
Collaborator

mmhat commented Sep 28, 2022

I am on it.

@mmhat mmhat self-assigned this Sep 28, 2022
mmhat added a commit to mmhat/dhall-haskell that referenced this issue Sep 28, 2022
@mmhat
Move types needed in Dhall.DirectoryTree to own module
6858f58 
In order to fix the Windows builds observed in dhall-lang#2452 we only include the
`FromDhall CUid` and `FromDhall CGid` instance only if we are on that
platform. Those types are not available there which caused the CI
failure.

Fixes dhall-lang#2452
@mmhat mmhat mentioned this issue Sep 28, 2022
Merged
@Gabriella439
Copy link
Collaborator

Just to clarify: does this only affect Windows?

@mmhat
Copy link
Collaborator

mmhat commented Sep 29, 2022

@Gabriella439 Yes, Unix systems are fine. The issue is caused by some missing types in the unix-compat package. It should ultimately be solved there and what I am trying here is to find a decent workaround.

@mmhat
Copy link
Collaborator

mmhat commented Sep 29, 2022

Also setting permissions does not work as expected on Windows: https://github.com/mmhat/dhall-haskell/actions/runs/3147765869/jobs/5117585580
I will disable setting permissions on Windows for now.

mmhat added a commit to mmhat/dhall-haskell that referenced this issue Sep 29, 2022
@mmhat
Disable setting file permissions on Windows
ed4d66c 
It is currently broken; See the discussion of dhall-lang#2452
@sjakobi sjakobi mentioned this issue Sep 29, 2022
Merged
mmhat added a commit to mmhat/dhall-haskell that referenced this issue Sep 30, 2022
@mmhat
Move types needed in Dhall.DirectoryTree to own module
243d2e3 
In order to fix the Windows builds observed in dhall-lang#2452 we only include the
`FromDhall CUid` and `FromDhall CGid` instance only if we are on that
platform. Those types are not available there which caused the CI
failure.

Fixes dhall-lang#2452
mmhat added a commit to mmhat/dhall-haskell that referenced this issue Sep 30, 2022
@mmhat
Disable setting file permissions on Windows
cf9b4fe 
It is currently broken; See the discussion of dhall-lang#2452
mmhat added a commit to mmhat/dhall-haskell that referenced this issue Sep 30, 2022
@mmhat
Move types needed in Dhall.DirectoryTree to own module
0691a21 
In order to fix the Windows builds observed in dhall-lang#2452 we only include the
`FromDhall CUid` and `FromDhall CGid` instance only if we are on that
platform. Those types are not available there which caused the CI
failure.

Fixes dhall-lang#2452
mmhat added a commit to mmhat/dhall-haskell that referenced this issue Sep 30, 2022
@mmhat
Disable setting file permissions on Windows
7255773 
It is currently broken; See the discussion of dhall-lang#2452
mmhat added a commit that referenced this issue Oct 1, 2022
@mmhat
Move types needed in Dhall.DirectoryTree to own module (#2455)
01c07b0 
In order to fix the Windows builds observed in #2452 we only include the
`FromDhall CUid` and `FromDhall CGid` instance only if we are on that
platform. Those types are not available there which caused the CI
failure.

Fixes #2452

* Use unsafe coercion for FromDhall instances of UserID/GroupID
* Added more to-directory-tree tests
* Warn on mismatch of file permissions on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmhat mmhat

Labels
CI Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move types needed in Dhall.DirectoryTree to own module mmhat/dhall-haskell
3 participants
@Gabriella439 @sjakobi @mmhat