Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSpec 3 compliance #11

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

mrerrormessage
Copy link

Hi, we're looking to use rspec3 on a new project and want the JUnitFormatter to work with a zero exit status. The formatter API has changed, but it wasn't too hard to get the code here working with it. Let me know if you have any issues or want things done differently.

@myronmarston
Copy link

Thanks for working on updating your formatters! Just a heads up...there will probably be a few more changes before 3.0 RC (the next release, due pretty soon) and then we'll keep the API very stable for a long time. @JonRowe is focused on formatter improvements and I know he'd be happy to help :).

@mrerrormessage
Copy link
Author

Thanks @JonRowe and @myronmarston for taking a look! Looking again at the formatters, I don't believe they need to subclass rspec formatters any more, so I will see if I can remove that to simplify the code a little bit. Very much looking forward to the next RC for RSpec 3!

@booleanbetrayal
Copy link

@myronmarston / @mrerrormessage - any update on this PR? Updating to 4.2 and RSpec 3, but definitely need JUnit parsing support for CI. Thanks!

@myronmarston
Copy link

@myronmarston / @mrerrormessage - any update on this PR? Updating to 4.2 and RSpec 3, but definitely need JUnit parsing support for CI. Thanks!

No update from me. I'm not involved in this repo at all, but can answer RSpec questions or provide general advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants