JUnitFormatter works with RSpec 3

[mrerrormessage]

No description provided.

[cbandy]

noise

[mrerrormessage]

you think I should leave it?

[cbandy]

In some places you changed the whitespace around examples and groups, in others you did not. Either way, I suppose.

(I'm assuming we're going to open a PR upstream?)

[mrerrormessage]

Fair enough, I'll make it consistent.

[cbandy]

Committed lib/rspec-extra-formatters/.junit_formatter.rb.swp and spec/rspec-extra-formatters/.junit_formatter_spec.rb.swp.

[cbandy]

Looks good. I recommend splitting the should-to-expect changes into their own commit. If necessary, the gemspec can depend on RSpec >= 2.11.0.

This would leave example-to-notification as a second commit and make it more obvious that the tests didn't change.

[mrerrormessage]

Comments addressed. I will need to fix up the tap formatter before all tests pass as well.

[cbandy]

Looks great.

[cbandy]

The spec for TapFormatter.start is a little awkward, but incorporating it into the existing test seems best for now.

[mrerrormessage]

I agree it is an awkward spec, that was my thought. Dump summary is completely not needed now that rspec is using the observer pattern.