Skip to content

Commit

Permalink
apacheGH-39327: [Java] define assemble descriptor for new custom mave…
Browse files Browse the repository at this point in the history
…n plugin project (apache#39331)

### Rationale for this change

To closes apache#39327

### What changes are included in this PR?

GitHub CI validation needs to [run](https://github.com/apache/arrow/blob/main/ci/scripts/java_full_build.sh#L52) `assembly:single` for that reason is needed to setup a descriptor ref. In the case of this maven plugin, I only propose to include "src" as part of the resources.

### Are these changes tested?

Yes, by 
````
mvn clean \
    install \
    assembly:single \
    source:jar \
    javadoc:jar \
    -Papache-release \
    -DdescriptorId=source-release
````

### Are there any user-facing changes?

No.

* Closes: apache#39327

Lead-authored-by: david dali susanibar arce <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: David Li <[email protected]>
  • Loading branch information
2 people authored and dgreiss committed Feb 17, 2024
1 parent e312295 commit 754e9b1
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions java/maven/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,27 @@
</execution>
</executions>
</plugin>
<!--
Generate custom Arrow Java Maven Plugin for module-info.java compiler.
Needed to pass GitHub CI validation `$ mvn assembly:single`
-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>single</goal>
</goals>
</execution>
</executions>
<configuration>
<descriptorRefs>
<descriptorRef>src</descriptorRef>
</descriptorRefs>
</configuration>
</plugin>
</plugins>
</build>

Expand Down

0 comments on commit 754e9b1

Please sign in to comment.