GH-39327: [Java] define assemble descriptor for new custom maven plugin project #39331

davisusanibar · 2023-12-20T23:04:32Z

Rationale for this change

To closes #39327

What changes are included in this PR?

GitHub CI validation needs to run assembly:single for that reason is needed to setup a descriptor ref. In the case of this maven plugin, I only propose to include "src" as part of the resources.

Are these changes tested?

Yes, by

mvn clean \
    install \
    assembly:single \
    source:jar \
    javadoc:jar \
    -Papache-release \
    -DdescriptorId=source-release

Are there any user-facing changes?

No.

Closes: [Java][CI] java-jars CI job is failing on the maven plugin #39327

davisusanibar · 2023-12-20T23:27:58Z

@github-actions crossbow submit java

github-actions · 2023-12-20T23:29:09Z

Unable to match any tasks for `java`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7281925382

davisusanibar · 2023-12-20T23:32:16Z

@github-actions crossbow submit java-jars

github-actions · 2023-12-20T23:34:55Z

Revision: 59c95c4

Submitted crossbow builds: ursacomputing/crossbow @ actions-a241771615

Task	Status
java-jars

java/maven/pom.xml

Co-authored-by: Sutou Kouhei <[email protected]>

davisusanibar · 2023-12-21T00:20:17Z

Could you please help me retry Build C++ libraries Ubuntu aarch64? @lidavidm / @kou

Current error:


The following tests FAILED:
	 53 - arrow-dataset-dataset-writer-test (Failed)
Error: `docker-compose --file /runner/_work/crossbow/crossbow/arrow/docker-compose.yml run --rm -e ARROW_JAVA_BUILD=OFF -e ARROW_JAVA_TEST=OFF java-jni-manylinux-2014` exited with a non-zero exit code 8, see the process log above.

kou · 2023-12-21T00:46:33Z

Retried!

davisusanibar · 2023-12-21T03:21:22Z

Retried!

Well, there will be an issue with Build C++ libraries in Ubuntu aarch64. Is there any issue related to that?

…en module project

davisusanibar · 2023-12-21T03:27:42Z

@github-actions crossbow submit java-jars

davisusanibar · 2023-12-21T03:28:24Z

Retried!

Well, there will be an issue with Build C++ libraries in Ubuntu aarch64. Is there any issue related to that?

Exclude failing tests to test the PR's scope

github-actions · 2023-12-21T03:29:54Z

Revision: 8d7c6bc

Submitted crossbow builds: ursacomputing/crossbow @ actions-4b8dd60adf

Task	Status
java-jars

kou · 2023-12-21T03:34:03Z

Well, there will be an issue with Build C++ libraries in Ubuntu aarch64. Is there any issue related to that?

#39326

lidavidm · 2023-12-21T13:34:07Z

ci/scripts/java_jni_manylinux_build.sh

@@ -115,7 +115,7 @@ if [ "${ARROW_BUILD_TESTS}" = "ON" ]; then
      # ImportError: ../grpc/_cython/cygrpc.cpython-38-aarch64-linux-gnu.so:
      # undefined symbol: vtable for std::__cxx11::basic_ostringstream<
      #   char, std::char_traits<char>, std::allocator<char> >
-      exclude_tests="${exclude_tests}|arrow-gcsfs-test"
+      exclude_tests="${exclude_tests}|arrow-gcsfs-test|arrow-dataset-dataset-writer-test"


nit: can you link the GitHub issue explaining why we are skipping this test?

It is a temporary workaround that only applies to testing this PR's scope. I think we should wait until #39326 is resolved. Please let me know if this sound great for you, or, do we should push this PR with this exclude test to main branch?

Are we sure #39326 will be resolved in time?

davisusanibar · 2023-12-29T14:58:28Z

@github-actions crossbow submit java-jars

github-actions · 2023-12-29T15:00:50Z

Revision: 60949fa

Submitted crossbow builds: ursacomputing/crossbow @ actions-0754aae5ab

Task	Status
java-jars

davisusanibar · 2023-12-29T16:16:04Z

@github-actions crossbow submit java-jar

github-actions · 2023-12-29T16:17:12Z

Unable to match any tasks for `java-jar`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/7358145715

davisusanibar · 2023-12-29T20:01:03Z

@github-actions crossbow submit java-jars

github-actions · 2023-12-29T20:03:26Z

Revision: 17bafae

Submitted crossbow builds: ursacomputing/crossbow @ actions-b3464c02d1

Task	Status
java-jars

kou

+1

I can't review whether this approach is optimal or not but CI is green.

conbench-apache-arrow · 2024-01-02T21:24:34Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 6b32b6d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

…n plugin project (apache#39331) ### Rationale for this change To closes apache#39327 ### What changes are included in this PR? GitHub CI validation needs to [run](https://github.com/apache/arrow/blob/main/ci/scripts/java_full_build.sh#L52) `assembly:single` for that reason is needed to setup a descriptor ref. In the case of this maven plugin, I only propose to include "src" as part of the resources. ### Are these changes tested? Yes, by ```` mvn clean \ install \ assembly:single \ source:jar \ javadoc:jar \ -Papache-release \ -DdescriptorId=source-release ```` ### Are there any user-facing changes? No. * Closes: apache#39327 Lead-authored-by: david dali susanibar arce <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: David Li <[email protected]>

fix: define assemble descriptor for custom maven plugin

59c95c4

davisusanibar requested a review from lidavidm as a code owner December 20, 2023 23:04

github-actions bot added Component: Java awaiting review Awaiting review labels Dec 20, 2023

kou reviewed Dec 20, 2023

View reviewed changes

java/maven/pom.xml Outdated Show resolved Hide resolved

github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Dec 20, 2023

Update java/maven/pom.xml

3d18feb

Co-authored-by: Sutou Kouhei <[email protected]>

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 20, 2023

fix: exclude arrow-dataset-dataset-writer-test to test changes on mav…

8d7c6bc

…en module project

davisusanibar requested review from assignUser and raulcd as code owners December 21, 2023 03:27

lidavidm approved these changes Dec 21, 2023

View reviewed changes

github-actions bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting change review Awaiting change review awaiting merge Awaiting merge labels Dec 21, 2023

fix: rollback exclude arrow-dataset-dataset-writer-test

60949fa

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 29, 2023

Merge branch 'main' into apacheGH-39327

17bafae

davisusanibar requested review from lidavidm and kou December 29, 2023 23:26

kou approved these changes Dec 30, 2023

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Dec 30, 2023

lidavidm approved these changes Jan 2, 2024

View reviewed changes

lidavidm merged commit 6b32b6d into apache:main Jan 2, 2024
16 of 17 checks passed

lidavidm removed the awaiting merge Awaiting merge label Jan 2, 2024

github-actions bot added the awaiting merge Awaiting merge label Jan 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-39327: [Java] define assemble descriptor for new custom maven plugin project #39331

GH-39327: [Java] define assemble descriptor for new custom maven plugin project #39331

davisusanibar commented Dec 20, 2023 •

edited by kou

Loading

davisusanibar commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

davisusanibar commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

davisusanibar commented Dec 21, 2023

kou commented Dec 21, 2023

davisusanibar commented Dec 21, 2023

davisusanibar commented Dec 21, 2023

davisusanibar commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

kou commented Dec 21, 2023

lidavidm Dec 21, 2023

davisusanibar Dec 21, 2023

lidavidm Dec 21, 2023

davisusanibar commented Dec 29, 2023

github-actions bot commented Dec 29, 2023

davisusanibar commented Dec 29, 2023

github-actions bot commented Dec 29, 2023

davisusanibar commented Dec 29, 2023

github-actions bot commented Dec 29, 2023

kou left a comment

conbench-apache-arrow bot commented Jan 2, 2024

GH-39327: [Java] define assemble descriptor for new custom maven plugin project #39331

GH-39327: [Java] define assemble descriptor for new custom maven plugin project #39331

Conversation

davisusanibar commented Dec 20, 2023 • edited by kou Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

davisusanibar commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

davisusanibar commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

davisusanibar commented Dec 21, 2023

kou commented Dec 21, 2023

davisusanibar commented Dec 21, 2023

davisusanibar commented Dec 21, 2023

davisusanibar commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

kou commented Dec 21, 2023

lidavidm Dec 21, 2023

Choose a reason for hiding this comment

davisusanibar Dec 21, 2023

Choose a reason for hiding this comment

lidavidm Dec 21, 2023

Choose a reason for hiding this comment

davisusanibar commented Dec 29, 2023

github-actions bot commented Dec 29, 2023

davisusanibar commented Dec 29, 2023

github-actions bot commented Dec 29, 2023

davisusanibar commented Dec 29, 2023

github-actions bot commented Dec 29, 2023

kou left a comment

Choose a reason for hiding this comment

conbench-apache-arrow bot commented Jan 2, 2024

davisusanibar commented Dec 20, 2023 •

edited by kou

Loading