Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add icp-api.io to default CSP; default to allow raw access #3327

Merged
merged 14 commits into from
Aug 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/audit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ jobs:
rustup default ${{ matrix.rust }}
cargo install --force --version ${{ matrix.cargo-audit }} cargo-audit --locked
- name: Audit
# ignores RUSTSEC-2020-0071 because it is 'only' in a dev dependency (ic-certified-responses -> ic-types -> chrono -> time)
run: |
cd sdk
cargo audit --no-fetch --db "${GITHUB_WORKSPACE}"/advisory-db
cargo audit --no-fetch --db "${GITHUB_WORKSPACE}"/advisory-db --ignore RUSTSEC-2020-0071
env:
RUST_BACKTRACE: 1

Expand Down
29 changes: 27 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
# dfx changelog

# 0.14.4

## DFX

### fix: added https://icp-api.io to the default Content-Security-Policy header

Existing projects will need to change this value in .ic-assets.json or .ic-assets.json5 to include https://icp-api.io

All projects will need to redeploy.

### fix: access to raw assets is now enabled by default

The default value for `allow_raw_access` is now `true`. This means that by default, the frontend canister will no longer restrict the access of traffic to the `<canister-id>.raw.icp0.io` domain, and will no longer automatically redirect all requests to the certified domain (`<canister-id>.icp0.io`), unless configured explicitly.

Note that existing projects that specify `"allow_raw_access": false` in .ic-assets.json5 will need to change or remove this value manually in order to allow raw access.

## Dependencies

### Updated candid to 0.9.0

### Updated cdk-rs to 0.10.0

### Frontend canister

- Module hash: d5c324fea6b0f8eaa9feede10b342b098f7cf64682e168e58fa2ca2bf028b96f
- https://github.com/dfinity/sdk/pull/3327

# 0.14.3

## Dependencies
Expand All @@ -12,8 +39,6 @@ This removes a dependency on OpenSSL in order to avoid spurious errors that refe

# 0.14.2

Note: Canister http functionality is broken. Do not release dfx until this is corrected. See https://dfinity.atlassian.net/browse/SDK-1129

## DFX

### feat: deprecate `dfx bootstrap` and `dfx replica` commands
Expand Down
Loading