fix: add icp-api.io to default CSP; default to allow raw access #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
changed the title
ghost
approved these changes
Aug 25, 2023
3 tasks
Co-authored-by: Yan Chen <[email protected]> Co-authored-by: Linwei Shang <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make redirects from raw to non-raw opt-in, rather than opt-out. The default
allow_raw_accesssetting for assets is now true, rather than false. This is in part because webviews on iOS and Android don't handle service workers very well.Added https://icp-api.io to the default Content-Security-Policy header.
Fixes # (issue)
How Has This Been Tested?
Checklist: