Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEB128 code: s/0x8F/0x7F/ #621

Merged
merged 1 commit into from
Aug 15, 2019
Merged

LEB128 code: s/0x8F/0x7F/ #621

merged 1 commit into from
Aug 15, 2019

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Aug 15, 2019

No description provided.

@nomeata nomeata added the automerge-squash When ready, merge (using squash) label Aug 15, 2019
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mergify mergify bot merged commit 567c86b into master Aug 15, 2019
@mergify mergify bot deleted the joachim/leb128fix branch August 15, 2019 20:37
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Aug 15, 2019
nomeata added a commit that referenced this pull request Aug 16, 2019
This is not running in CI, see README for instructions.

Would have caught #621. Does not seem to catch any more.

It only tests round-tripping leb128 and sleb128 from int so far. See
branch `joachim/afl` for a more elaborate setup of fuzzing the IDL
parser against out-of-memory-reads.
nomeata added a commit that referenced this pull request Aug 18, 2019
This is not running in CI, see README for instructions.

Would have caught #621. Does not seem to catch any more bugs.

It only tests round-tripping leb128 and sleb128 from int so far. See
branch `joachim/afl` for a more elaborate setup of fuzzing the IDL
parser against out-of-memory-reads.
dfinity-bot added a commit that referenced this pull request Feb 22, 2024
## Changelog for motoko-base:
Branch: next-moc
Commits: [dfinity/motoko-base@520ccf5d...712d0587](dfinity/motoko-base@520ccf5...712d058)

* [`cba05e81`](dfinity/motoko-base@cba05e8) Publish on Mops ([dfinity/motoko-base⁠#618](https://github.com/dfinity/motoko-base/issues/618))
* [`d81f5527`](dfinity/motoko-base@d81f552) Add commit hash to `matchers` dependency ([dfinity/motoko-base⁠#621](https://github.com/dfinity/motoko-base/issues/621))
* [`c86d76ff`](dfinity/motoko-base@c86d76f) doc: update `List.mo` ([dfinity/motoko-base⁠#616](https://github.com/dfinity/motoko-base/issues/616))
* [`4c2a90e7`](dfinity/motoko-base@4c2a90e) Fix compiler warning in `Array.take()` method ([dfinity/motoko-base⁠#611](https://github.com/dfinity/motoko-base/issues/611))
mergify bot pushed a commit that referenced this pull request Feb 22, 2024
## Changelog for motoko-base:
Branch: next-moc
Commits: [dfinity/motoko-base@520ccf5d...712d0587](dfinity/motoko-base@520ccf5...712d058)

* [`cba05e81`](dfinity/motoko-base@cba05e8) Publish on Mops ([dfinity/motoko-base⁠#618](https://github.com/dfinity/motoko-base/issues/618))
* [`d81f5527`](dfinity/motoko-base@d81f552) Add commit hash to `matchers` dependency ([dfinity/motoko-base⁠#621](https://github.com/dfinity/motoko-base/issues/621))
* [`c86d76ff`](dfinity/motoko-base@c86d76f) doc: update `List.mo` ([dfinity/motoko-base⁠#616](https://github.com/dfinity/motoko-base/issues/616))
* [`4c2a90e7`](dfinity/motoko-base@4c2a90e) Fix compiler warning in `Array.take()` method ([dfinity/motoko-base⁠#611](https://github.com/dfinity/motoko-base/issues/611))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants