Improve pretty printing #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
approved these changes
Aug 14, 2019
src/as_values/prim.ml
Outdated
| let i = Conv.of_signed_Word32 (as_word32 v) | ||
| in if i <= 0x10FFFF then k (Char i) else raise (Invalid_argument "codepoint out of bounds") | ||
| let i = Conv.int_of_word32_u (as_word32 v) | ||
| in if i < 0x110000 then k (Char i) else raise (Invalid_argument "character value out of bounds") |
There was a problem hiding this comment.
This will cause a conflict with master.
| @@ -82,14 +81,6 @@ escape ch | '\\' `elem` show ch = "\\u{" <> hex (fromEnum ch) <> "}" | |||
| escape '"' = "\\\"" | |||
| escape ch = pure ch | |||
|
|
|||
| prop_charToText (UTF8 char) = monadicIO $ do | |||
| let testCase = "assert (switch (decodeUTF8 (charToText '" | |||
There was a problem hiding this comment.
I'll bring this test back soon (with t.chars().next()).
There was a problem hiding this comment.
I am working on it, may land in the branch soon.
There was a problem hiding this comment.
Done and pushed. Please pull before rebasing.
Closed
|
Thanks for this! |
dfinity-bot
added a commit
that referenced
this pull request
Feb 22, 2024
## Changelog for motoko-base: Branch: next-moc Commits: [dfinity/motoko-base@520ccf5d...712d0587](dfinity/motoko-base@520ccf5...712d058) * [`cba05e81`](dfinity/motoko-base@cba05e8) Publish on Mops ([dfinity/motoko-base#618](https://github.com/dfinity/motoko-base/issues/618)) * [`d81f5527`](dfinity/motoko-base@d81f552) Add commit hash to `matchers` dependency ([dfinity/motoko-base#621](https://github.com/dfinity/motoko-base/issues/621)) * [`c86d76ff`](dfinity/motoko-base@c86d76f) doc: update `List.mo` ([dfinity/motoko-base#616](https://github.com/dfinity/motoko-base/issues/616)) * [`4c2a90e7`](dfinity/motoko-base@4c2a90e) Fix compiler warning in `Array.take()` method ([dfinity/motoko-base#611](https://github.com/dfinity/motoko-base/issues/611))
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
## Changelog for motoko-base: Branch: next-moc Commits: [dfinity/motoko-base@520ccf5d...712d0587](dfinity/motoko-base@520ccf5...712d058) * [`cba05e81`](dfinity/motoko-base@cba05e8) Publish on Mops ([dfinity/motoko-base#618](https://github.com/dfinity/motoko-base/issues/618)) * [`d81f5527`](dfinity/motoko-base@d81f552) Add commit hash to `matchers` dependency ([dfinity/motoko-base#621](https://github.com/dfinity/motoko-base/issues/621)) * [`c86d76ff`](dfinity/motoko-base@c86d76f) doc: update `List.mo` ([dfinity/motoko-base#616](https://github.com/dfinity/motoko-base/issues/616)) * [`4c2a90e7`](dfinity/motoko-base@4c2a90e) Fix compiler warning in `Array.take()` method ([dfinity/motoko-base#611](https://github.com/dfinity/motoko-base/issues/611))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tweaks to our pretty printers:
debug_showon empty arrays (would just show"]"before)Side note: we have as many as 4 implementations of pretty-printing for values: in value.ml, in show.ml, in coverage.ml, and in prelude.as. Sigh.