Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Main sync develop #6047

Merged
merged 18 commits into from
Nov 4, 2024
Merged

misc: Main sync develop #6047

merged 18 commits into from
Nov 4, 2024

Conversation

vikramdevtron
Copy link
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


prkhrkat and others added 18 commits October 15, 2024 15:34
* error handling while creating github repo

* Replaced != with <> for PostgreSQL compatibility
* Synced all chart changes

* Updated VPA in sts chart

* chnages in sts SM
* plugin fix

* reverted errnorows change
* migration seq rename

* migration seq fix and renamed
* misc: Replaced != with <> for PostgreSQL compatibility (#5987)

* error handling while creating github repo

* Replaced != with <> for PostgreSQL compatibility

* removed deployment group validation when deleting CD pipelines (#5989)

* fix for multiple param of filter in helm app list (#6013)

* fix: plugin getByName method error handling (#6016)

* plugin fix

* reverted errnorows change

* dep import

---------

Co-authored-by: prakhar katiyar <[email protected]>
Co-authored-by: kartik-579 <[email protected]>
…d another and sql clause to filter pipeline on
…n-product-fix-oss

fix: fix for showing inaccurate data in template/list api while fetching previous deployments list in template/list api, output shown was cartesian product of deployment_template_history and wfr
@vikramdevtron vikramdevtron changed the title misc: Main sync develop 4nov misc: Main sync develop Nov 4, 2024
@vikramdevtron vikramdevtron changed the base branch from main to develop November 4, 2024 11:17
Copy link

gitguardian bot commented Nov 4, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9257608 Triggered Base64 AWS keys fb1cbf5 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/test-values.json View secret
2763127 Triggered Generic High Entropy Secret fb1cbf5 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret fb1cbf5 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret fb1cbf5 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret fb1cbf5 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

sonarqubecloud bot commented Nov 4, 2024

@vikramdevtron vikramdevtron merged commit 9944e19 into develop Nov 4, 2024
11 checks passed
@vikramdevtron vikramdevtron deleted the main-sync-develop-4nov branch November 4, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants