Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refrence charts hotfix #6018

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: refrence charts hotfix #6018

merged 1 commit into from
Oct 23, 2024

Conversation

kamal-devtron
Copy link
Contributor

@kamal-devtron kamal-devtron commented Oct 23, 2024 •
edited by YashasviDevtron
Loading

  • Synced all chart changes

  • Updated VPA in sts chart

  • chnages in sts SM

Description

Fixes #5935

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@kamal-devtron
Charts hotfix (#1992)
b25dd3c 
* Synced all chart changes

* Updated VPA in sts chart

* chnages in sts SM
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2024
View reviewed changes
scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/templates/statefulset.yaml
{{- end }}
{{- if $.Values.serviceAccountName }}
serviceAccountName: {{ $.Values.serviceAccountName }}
{{- else }}
serviceAccountName: {{ template "serviceAccountName" . }}
{{- end }}
{{- if $.Values.schedulerName }}
schedulerName: {{ .Values.schedulerName }}
{{- end }}

Check warning

Code scanning / SonarCloud

Service account permissions should be restricted Medium

Bind this Service Account to RBAC or disable "automountServiceAccountToken". See more on SonarCloud
@prakarsh-dt prakarsh-dt merged commit dc012c0 into release-candidate-v0.21.0 Oct 23, 2024
5 of 7 checks passed
@prakarsh-dt prakarsh-dt deleted the chart-hotfix-oss branch October 23, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakarsh-dt prakarsh-dt prakarsh-dt approved these changes

@pawan-mehta-dt pawan-mehta-dt pawan-mehta-dt approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamal-devtron @prakarsh-dt @pawan-mehta-dt