remove unused parameters and fix code smells

src/dsp_worker.c

@@ -7,7 +7,7 @@
 #include "api.h"
 #include "lpf.h"
 
-static int write_to_file(dsp_worker *config, float complex *filter_output, size_t filter_output_len) {
+static int write_to_file(dsp_worker *config, const float complex *filter_output, size_t filter_output_len) {
   size_t n_written;
   if (config->file != NULL) {
     n_written = fwrite(filter_output, sizeof(float complex), filter_output_len, config->file);
@@ -25,7 +25,7 @@ static int write_to_file(dsp_worker *config, float complex *filter_output, size_
   }
 }
 
-static int write_to_socket(int client_socket, float complex *filter_output, size_t filter_output_len) {
+static int write_to_socket(int client_socket, const float complex *filter_output, size_t filter_output_len) {
   size_t total_len = filter_output_len * sizeof(float complex);
   size_t left = total_len;
   while (left > 0) {

src/sdr/airspy_device.c

@@ -27,7 +27,7 @@ struct airspy_device_t {
   airspy_lib *lib;
 };
 
-int airspy_device_create(uint32_t id, struct server_config *server_config, airspy_lib *lib, void (*sdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin) {
+int airspy_device_create(struct server_config *server_config, airspy_lib *lib, void (*sdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin) {
   struct airspy_device_t *device = malloc(sizeof(struct airspy_device_t));
   if (device == NULL) {
     return -ENOMEM;

src/sdr/airspy_device.h

@@ -4,7 +4,7 @@
 #include "../config.h"
 #include "airspy_lib.h"
 
-int airspy_device_create(uint32_t id, struct server_config *server_config, airspy_lib *lib, void (*sdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin);
+int airspy_device_create(struct server_config *server_config, airspy_lib *lib, void (*sdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin);
 
 void airspy_device_destroy(void *plugin);
 

src/sdr/hackrf_device.c

@@ -24,7 +24,12 @@ typedef struct {
   hackrf_lib *lib;
 } hackrf_wrapper;
 
-int hackrf_device_create(uint32_t id, struct server_config *server_config, hackrf_lib *lib, void (*sdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin) {
+int hackrf_device_create(struct server_config *server_config, hackrf_lib *lib, void (*sdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin) {
+  int code = lib->hackrf_init();
+  if (code != 0) {
+    fprintf(stderr, "<3>unable to initialize hackrf library: %s (%d)\n", lib->hackrf_error_name(code), code);
+    return code;
+  }
   hackrf_wrapper *wrapper = malloc(sizeof(hackrf_wrapper));
   if (wrapper == NULL) {
     return -ENOMEM;
@@ -34,7 +39,6 @@ int hackrf_device_create(uint32_t id, struct server_config *server_config, hackr
   wrapper->sdr_callback = sdr_callback;
   wrapper->ctx = ctx;
   wrapper->server_config = server_config;
-  ERROR_CHECK(lib->hackrf_init(), "<3>unable to initialize hackrf library");
   fprintf(stdout, "hackrf device created\n");
   *plugin = wrapper;
   return 0;

src/sdr/hackrf_device.h

@@ -4,7 +4,7 @@
 #include "../config.h"
 #include "hackrf_lib.h"
 
-int hackrf_device_create(uint32_t id, struct server_config *server_config, hackrf_lib *lib, void (*sdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin);
+int hackrf_device_create(struct server_config *server_config, hackrf_lib *lib, void (*sdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin);
 
 void hackrf_device_destroy(void *plugin);
 

src/sdr/rtlsdr_device.c

@@ -59,7 +59,7 @@ int find_nearest_gain(struct rtlsdr_device_t *dev, int target_gain, int *nearest
   return 0;
 }
 
-int rtlsdr_device_create(uint32_t id, struct server_config *server_config, rtlsdr_lib *lib, void (*rtlsdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin) {
+int rtlsdr_device_create(struct server_config *server_config, rtlsdr_lib *lib, void (*rtlsdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin) {
   struct rtlsdr_device_t *device = malloc(sizeof(struct rtlsdr_device_t));
   if (device == NULL) {
     return -ENOMEM;

src/sdr/rtlsdr_device.h

@@ -4,7 +4,7 @@
 #include "rtlsdr_lib.h"
 #include "../config.h"
 
-int rtlsdr_device_create(uint32_t id, struct server_config *server_config, rtlsdr_lib *lib, void (*sdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin);
+int rtlsdr_device_create(struct server_config *server_config, rtlsdr_lib *lib, void (*sdr_callback)(uint8_t *buf, uint32_t len, void *ctx), void *ctx, void **plugin);
 
 void rtlsdr_device_destroy(void *plugin);
 

src/sdr_device.c

@@ -98,15 +98,15 @@ int sdr_device_start(client_config *config, sdr_device *device) {
     int code = -1;
     switch (config->sdr_type) {
       case SDR_TYPE_RTL: {
-        code = rtlsdr_device_create(1, device->server_config, device->rtllib, device->sdr_callback, device->ctx, &device->plugin);
+        code = rtlsdr_device_create(device->server_config, device->rtllib, device->sdr_callback, device->ctx, &device->plugin);
         break;
       }
       case SDR_TYPE_AIRSPY: {
-        code = airspy_device_create(1, device->server_config, device->airspy, device->sdr_callback, device->ctx, &device->plugin);
+        code = airspy_device_create(device->server_config, device->airspy, device->sdr_callback, device->ctx, &device->plugin);
         break;
       }
       case SDR_TYPE_HACKRF: {
-        code = hackrf_device_create(1, device->server_config, device->hackrf, device->sdr_callback, device->ctx, &device->plugin);
+        code = hackrf_device_create(device->server_config, device->hackrf, device->sdr_callback, device->ctx, &device->plugin);
         break;
       }
       default: {