Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add window.self read-only property #4131

Merged
merged 2 commits into from
Feb 26, 2020
Merged

add window.self read-only property #4131

merged 2 commits into from
Feb 26, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju requested a review from ry February 25, 2020 20:50
@bartlomieju
Copy link
Member Author

CC @guybedford

ry
ry reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if some test exercised this. You don't have to make a new one, just add this somewhere.

@bartlomieju bartlomieju requested a review from ry February 25, 2020 22:31
ry
ry approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 0e37184 into denoland:master Feb 26, 2020
@bartlomieju bartlomieju deleted the global_this_self branch February 26, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define the "self" global name
2 participants
@bartlomieju @ry