add window.self read-only property (#4131)

denoland · Feb 26, 2020 · 0e37184 · 0e37184
1 parent 5946808
commit 0e37184
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/cli/js/globals_test.ts b/cli/js/globals_test.ts
@@ -9,14 +9,26 @@ test(function windowExists(): void {
   assert(window != null);
 });
 
+test(function selfExists(): void {
+  assert(self != null);
+});
+
 test(function windowWindowExists(): void {
   assert(window.window === window);
 });
 
+test(function windowSelfExists(): void {
+  assert(window.self === window);
+});
+
 test(function globalThisEqualsWindow(): void {
   assert(globalThis === window);
 });
 
+test(function globalThisEqualsSelf(): void {
+  assert(globalThis === self);
+});
+
 test(function DenoNamespaceExists(): void {
   assert(Deno != null);
 });

diff --git a/cli/js/lib.deno.window.d.ts b/cli/js/lib.deno.window.d.ts
@@ -9,13 +9,15 @@
 
 declare interface Window extends WindowOrWorkerGlobalScope {
   window: Window & WindowOrWorkerGlobalScope & typeof globalThis;
+  self: Window & WindowOrWorkerGlobalScope & typeof globalThis;
   onload: Function | undefined;
   onunload: Function | undefined;
   crypto: Crypto;
   Deno: typeof Deno;
 }
 
 declare const window: Window & WindowOrWorkerGlobalScope & typeof globalThis;
+declare const self: Window & WindowOrWorkerGlobalScope & typeof globalThis;
 declare const onload: Function | undefined;
 declare const onunload: Function | undefined;
 declare const crypto: Crypto;

diff --git a/cli/js/runtime_main.ts b/cli/js/runtime_main.ts
@@ -32,6 +32,7 @@ Deno[Deno.symbols.internal] = internalObject;
 
 export const mainRuntimeGlobalProperties = {
   window: readOnly(globalThis),
+  self: readOnly(globalThis),
   Deno: readOnly(Deno),
 
   crypto: readOnly(csprng),