Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(attachement): if champ attachement is already destroyed don’t crash #11272

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

tchak
Copy link
Member

@tchak tchak commented Jan 29, 2025

@tchak tchak added the bug label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.39%. Comparing base (0c14bba) to head (d03c14b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/controllers/attachments_controller.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11272      +/-   ##
==========================================
- Coverage   84.39%   84.39%   -0.01%     
==========================================
  Files        1202     1202              
  Lines       26431    26432       +1     
  Branches     4974     4974              
==========================================
  Hits        22307    22307              
- Misses       4124     4125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchak tchak enabled auto-merge January 29, 2025 13:43
@tchak tchak added this pull request to the merge queue Jan 29, 2025
Merged via the queue into demarches-simplifiees:main with commit c0fe3c7 Jan 29, 2025
18 checks passed
@tchak tchak deleted the fix-attachement-destroy branch January 29, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Communiqué, ou a ne pas communiqué
Development

Successfully merging this pull request may close these issues.

2 participants