Merge pull request #11272 from tchak/fix-attachement-destroy

fix(attachement): if champ attachement is already destroyed don’t crash
demarches-simplifiees · Jan 29, 2025 · c0fe3c7 · c0fe3c7
2 parents 0c14bba + d03c14b
commit c0fe3c7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/app/controllers/attachments_controller.rb b/app/controllers/attachments_controller.rb
@@ -23,13 +23,13 @@ def destroy
 
     if champ?
       @attachment = champ.piece_justificative_file.find { _1.blob.id == @blob.id }
+      @attachment&.purge_later
+      champ.piece_justificative_file.reload
     else
+      @attachment.purge_later
       @attachment_options = attachment_options
     end
 
-    @attachment.purge_later
-    @champ.piece_justificative_file.reload if champ?
-
     flash.notice = 'La pièce jointe a bien été supprimée.'
 
     respond_to do |format|