Corrige les défaut d'accessibilité de la page de création de compte accessibilité #10822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inseo
force-pushed
the
a11y-fix-process-create-account-bis
branch
from
6f76eca to
29141d6
Compare
inseo
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10822 +/- ##
==========================================
- Coverage 84.70% 84.68% -0.02%
==========================================
Files 1130 1130
Lines 25055 25055
Branches 4699 4699
==========================================
- Hits 21222 21219 -3
- Misses 3833 3836 +3 ☔ View full report in Codecov by Sentry. |
inseo
force-pushed
the
a11y-fix-process-create-account-bis
branch
from
29141d6 to
b0f8b7a
Compare
|
@colin : Reprise de la PR précédente (je ne m'en sortais pas avec le rebase... -_-) incluant les modifications demandées. |
inseo
force-pushed
the
a11y-fix-process-create-account-bis
branch
2 times, most recently
from
21b3e90 to
fc07547
Compare
inseo
force-pushed
the
a11y-fix-process-create-account-bis
branch
3 times, most recently
from
471a7c6 to
f5a3474
Compare
mfo
reviewed
Sep 30, 2024
| dossiers_path(statut: 'traites', procedure_id: params[:procedure_id]), | ||
| active: @statut == 'traites', | ||
| badge: number_with_html_delimiter(@dossiers_traites.count)) | ||
| - if @user_dossiers.present? || @dossiers_traites.present? || @dossiers_invites.present? || @dossiers_close_to_expiration.present? || @dossiers_supprimes.present? || @dossier_transferes.present? |
There was a problem hiding this comment.
Suggested change
| - if @user_dossiers.present? || @dossiers_traites.present? || @dossiers_invites.present? || @dossiers_close_to_expiration.present? || @dossiers_supprimes.present? || @dossier_transferes.present? | |
| - if [@user_dossiers, @dossiers_traites, @dossiers_invites, @dossiers_close_to_expiration, @dossiers_supprimes, @dossier_transferes].any?(&:present?) |
There was a problem hiding this comment.
Suggestion appliquée.
Merci @mfo !
mfo
approved these changes
Sep 30, 2024
inseo
force-pushed
the
a11y-fix-process-create-account-bis
branch
from
f5a3474 to
480c8f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
La PR vise à :
navcontenante en l'absence de navigation secondaire ;Après
Avant
.fr-grid-row.fr-grid-row--guttersen l'absence de contenu ;Après
Avant
Après
Perte.de.focus.-.apres.mp4
Avant
Perte.de.focus.-.avant.mp4