Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[outdated] Corrige les défaut d'accessibilité de la page de création de compte #10684

Closed
wants to merge 9 commits into from

Conversation

inseo
Copy link
Contributor

@inseo inseo commented Aug 9, 2024

La PR vise à :

  • Compléter le titre de page ;
  • Supprimer une liste à un seul élément ;
  • Expliciter la signification de l'astérisque ;
  • Supprimer un commentaire HTML ;
  • Supprimer la balise nav contenante en l'absence de navigation secondaire ;
    Après
    Capture d’écran 2024-08-12 à 15 56 33

Avant
Capture d’écran 2024-08-12 à 15 54 28

  • Et éviter la perte du focus lorsqu'une suggestion est acceptée ou refusée.

Après
https://github.com/user-attachments/assets/2e1d145d-e7a2-44de-af4d-e013f6b91a59

Avant
https://github.com/user-attachments/assets/4898fc90-a390-450e-9ca8-9cf7216bba4f

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.30%. Comparing base (6b322d6) to head (e976006).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (6b322d6) and HEAD (e976006). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (6b322d6) HEAD (e976006)
16 6
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10684      +/-   ##
==========================================
- Coverage   84.63%   77.30%   -7.34%     
==========================================
  Files        1131     1131              
  Lines       25058    25505     +447     
  Branches     4686     4540     -146     
==========================================
- Hits        21209    19717    -1492     
- Misses       3849     5788    +1939     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inseo inseo force-pushed the a11y-fix-process-create-account branch from b4f98c4 to b6f7ad0 Compare August 9, 2024 15:46
@inseo inseo force-pushed the a11y-fix-process-create-account branch from 22b7acf to 93702b3 Compare August 14, 2024 07:59
@inseo
Copy link
Contributor Author

inseo commented Aug 14, 2024

Merci @Benoit-MINT pour le dépannage des tests. :)

Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 petites remarques en commentaires avant de merger :

  • sur le markup et la fusion de 2 colonnes
  • est-ce que tu pourras fusionner les 2 derniers commits de la PR car ils sont liés ? (celui qui évitee le nav vide et ses tests lié au cache) (ping moi si tu sais pas comment faire ça)

Comment on lines +22 to +23
- if @procedures_for_select.size > 1
= render Dossiers::UserProcedureFilterComponent.new(procedures_for_select: @procedures_for_select)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce changement ne met plus le filtre des démarches dans sa propre colonne, mais regroupe tout dans la même colonne avec le champ de recherche. Est-ce intentionnel ?

Si non, pour être sûr de ne pas avoir de .fr-col vide, je pense qu'on pourrait embriquer .fr-col sous le if, ça donnerait quelque chose comme :

 - if current_user.dossiers.count > 2 || current_user.dossiers_invites.count > 2  || @procedures_for_select.size > 1
   .fr-grid-row.fr-grid-row--gutters
      - if current_user.dossiers.count > 2 || current_user.dossiers_invites.count > 2
        .fr-col
           #search-2 ...
      - if @procedures_for_select.size > 1
        .fr-col
           = render Dossiers::UserProcedureFilterComponent.new(procedures_for_select: @procedures_for_select)

@inseo inseo force-pushed the a11y-fix-process-create-account branch from 5f11a14 to e976006 Compare September 19, 2024 09:17
@inseo inseo closed this Sep 19, 2024
@inseo inseo changed the title Corrige les défaut d'accessibilité de la page de création de compte [outdated] Corrige les défaut d'accessibilité de la page de création de compte Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: poubelle ou duplicat
Development

Successfully merging this pull request may close these issues.

2 participants