-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[outdated] Corrige les défaut d'accessibilité de la page de création de compte #10684
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10684 +/- ##
==========================================
- Coverage 84.63% 77.30% -7.34%
==========================================
Files 1131 1131
Lines 25058 25505 +447
Branches 4686 4540 -146
==========================================
- Hits 21209 19717 -1492
- Misses 3849 5788 +1939 ☔ View full report in Codecov by Sentry. |
b4f98c4
to
b6f7ad0
Compare
22b7acf
to
93702b3
Compare
Merci @Benoit-MINT pour le dépannage des tests. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 petites remarques en commentaires avant de merger :
- sur le markup et la fusion de 2 colonnes
- est-ce que tu pourras fusionner les 2 derniers commits de la PR car ils sont liés ? (celui qui évitee le nav vide et ses tests lié au cache) (ping moi si tu sais pas comment faire ça)
- if @procedures_for_select.size > 1 | ||
= render Dossiers::UserProcedureFilterComponent.new(procedures_for_select: @procedures_for_select) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ce changement ne met plus le filtre des démarches dans sa propre colonne, mais regroupe tout dans la même colonne avec le champ de recherche. Est-ce intentionnel ?
Si non, pour être sûr de ne pas avoir de .fr-col vide, je pense qu'on pourrait embriquer .fr-col sous le if, ça donnerait quelque chose comme :
- if current_user.dossiers.count > 2 || current_user.dossiers_invites.count > 2 || @procedures_for_select.size > 1
.fr-grid-row.fr-grid-row--gutters
- if current_user.dossiers.count > 2 || current_user.dossiers_invites.count > 2
.fr-col
#search-2 ...
- if @procedures_for_select.size > 1
.fr-col
= render Dossiers::UserProcedureFilterComponent.new(procedures_for_select: @procedures_for_select)
5f11a14
to
e976006
Compare
La PR vise à :
nav
contenante en l'absence de navigation secondaire ;Après
Avant

Après
https://github.com/user-attachments/assets/2e1d145d-e7a2-44de-af4d-e013f6b91a59
Avant
https://github.com/user-attachments/assets/4898fc90-a390-450e-9ca8-9cf7216bba4f