Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ instructeur je peux voir les pjs envoyées par la messagerie dans l‘onglet "pièces jointes" #10572

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

E-L-T
Copy link
Contributor

@E-L-T E-L-T commented Jul 2, 2024

closes #10500

  • Ajoute les pièces jointes envoyées par l‘usager ou l‘instructeur dans la galerie
  • Sous la miniature on indique "Messagerie"
Capture d’écran 2024-07-02 à 16 53 25

Copy link

what-the-diff bot commented Jul 2, 2024

PR Summary

  • Enhanced Condition Checking in blob_image_processor_concern.rb
    In 'blob_image_processor_concern.rb', a new condition was added to improve the method 'representation_required?'. With this update, the system now checks if the attachments are associated with comments in the system, increasing our ability to customize user interaction based on attachment types.

  • Improved Display of Comment Attachments in pieces_jointes.html.haml
    Code was added to 'pieces_jointes.html.haml' that allows the system to display attachments associated with comments. Especially noteworthy changes include the capabilities to generate previews and handle various formats such as images and PDF files. This should improve user experience by providing previews of attachments without requiring to download them first.

  • Addition of New Rake Tasks for Attachment Handling
    Two new rake tasks were incorporated in the 'deployment' directory. These tasks can generate previews and handle different versions (variants) for comment-specific attachments. This not only saves time but also provides a more efficient way of handling attachments associated with comments. These enhancements should further improve our content management and display capabilities.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (b66d83a) to head (5fbe2da).

Files Patch % Lines
...ce/create_previews_for_pjs_from_messagerie_task.rb 81.25% 3 Missing ⚠️
...e/create_variants_for_pjs_from_messagerie__task.rb 83.33% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10572   +/-   ##
=======================================
  Coverage   80.44%   80.45%           
=======================================
  Files        1235     1237    +2     
  Lines       26306    26349   +43     
  Branches     4723     4729    +6     
=======================================
+ Hits        21163    21200   +37     
- Misses       5143     5149    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@E-L-T E-L-T force-pushed the add-pj-from-messagerie-to-gallery branch 8 times, most recently from 2e5a1d5 to c6e2daa Compare July 3, 2024 08:33
@E-L-T E-L-T force-pushed the add-pj-from-messagerie-to-gallery branch 7 times, most recently from 4463ab2 to f4f5bc2 Compare July 11, 2024 09:40
@E-L-T E-L-T force-pushed the add-pj-from-messagerie-to-gallery branch from f4f5bc2 to 5fbe2da Compare July 22, 2024 08:07
@E-L-T E-L-T marked this pull request as ready for review July 22, 2024 08:17
@tchak tchak added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@tchak tchak added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit 9d7d7da Jul 30, 2024
18 checks passed
@tchak tchak deleted the add-pj-from-messagerie-to-gallery branch July 30, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants