Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technique : déplace les traitements d‘images côté jobs #10641

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

E-L-T
Copy link
Contributor

@E-L-T E-L-T commented Jul 24, 2024

closes #10581

Cette PR :

  • redimensionne les logos en background
  • déplace le désinterlaçage des png en background
  • déplace en background la creation de représentations pour les contenus uploadés avec ActionText

A priori tous les traitements d'image sont maintenant côté jobs. On devrait donc pouvoir supprimer ImageMagick des machines web

@E-L-T E-L-T force-pushed the move-image-treatment-to-jobs branch 3 times, most recently from 3a31dcd to a0f2f9e Compare July 24, 2024 09:16
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 74.35897% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.55%. Comparing base (7693d21) to head (37a0188).
Report is 203 commits behind head on main.

Files with missing lines Patch % Lines
app/controllers/procedures_controller.rb 0.00% 6 Missing ⚠️
app/services/uninterlace_service.rb 76.92% 3 Missing ⚠️
app/jobs/image_processor_job.rb 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10641      +/-   ##
==========================================
- Coverage   84.60%   84.55%   -0.05%     
==========================================
  Files        1119     1119              
  Lines       24756    24761       +5     
  Branches     4612     4610       -2     
==========================================
- Hits        20945    20937       -8     
- Misses       3811     3824      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@E-L-T E-L-T force-pushed the move-image-treatment-to-jobs branch from a0f2f9e to 7227379 Compare July 24, 2024 09:33
@E-L-T E-L-T force-pushed the move-image-treatment-to-jobs branch 6 times, most recently from 94742fc to c10c57e Compare August 30, 2024 08:40
@E-L-T E-L-T marked this pull request as ready for review August 30, 2024 09:06
Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression que le fichier qui contient le concern UninterlacePngConcern peut-être supprimé aussi ?

@E-L-T
Copy link
Contributor Author

E-L-T commented Aug 30, 2024

J'ai l'impression que le fichier qui contient le concern UninterlacePngConcern peut-être supprimé aussi ?

Oui bien vu 👍

@E-L-T E-L-T force-pushed the move-image-treatment-to-jobs branch from ba0b232 to 07d216e Compare August 30, 2024 11:37
@E-L-T E-L-T force-pushed the move-image-treatment-to-jobs branch from 07d216e to 64a9f9f Compare August 30, 2024 12:28
@E-L-T E-L-T force-pushed the move-image-treatment-to-jobs branch from 64a9f9f to 37a0188 Compare August 30, 2024 14:37
@E-L-T E-L-T added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 9697061 Sep 17, 2024
18 checks passed
@E-L-T E-L-T deleted the move-image-treatment-to-jobs branch September 17, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Technique : transférer le traitement d‘images en background
3 participants