Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint fuzzing #1236

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
66edc7f
Adds an `openPair` function
jalextowle Nov 20, 2024
2614a15
Removes some outdated comments
jalextowle Nov 20, 2024
8a557f6
Added governance fees to the mint function
jalextowle Nov 23, 2024
4f75460
Updated the implementation of `HyperdrivePair`
jalextowle Nov 26, 2024
c96d744
Updated the `mint` logic and wired it up
jalextowle Nov 26, 2024
be28b36
Added unit test cases for the `mint` function
jalextowle Nov 26, 2024
94a124a
Adds comprehensive unit tests for the mint function
jalextowle Nov 27, 2024
75bd986
Adds a `minOutput` parameter to `mint`
jalextowle Dec 4, 2024
7817f25
Wrote a comprehensive integration test suite for the `mint` function
jalextowle Dec 6, 2024
1daa62f
Started implementing `burn`
jalextowle Jan 2, 2025
f3c1627
Made some targeted fixes to `mint`
jalextowle Jan 2, 2025
886ad43
Added zombie interest to the `burn` flow and cleaned up `HyperdrivePair`
jalextowle Jan 3, 2025
e748cf9
Started adding a test suite for the `burn` function
jalextowle Jan 4, 2025
788ea8b
Added the remaining test cases. Some of them are broken.
jalextowle Jan 4, 2025
22a3871
Fixed the remaining `burn` unit tests
jalextowle Jan 6, 2025
39b5573
Added an integration test suite for `burn`
jalextowle Jan 7, 2025
9399732
Bumping solidity version of mint to match rest of repo (#1235)
slundqui Jan 9, 2025
dd155a8
Added tests for zombie interest for `mint` and `burn`
jalextowle Jan 10, 2025
e6bc826
Added more integration tests for `mint` and `burn`
jalextowle Jan 10, 2025
1203d12
Added a negative interest test for `mint`
jalextowle Jan 10, 2025
f96ea1f
Addressed review feedback from @Sean329
jalextowle Jan 10, 2025
bcc9c16
Adding script for mint fuzz
Jan 9, 2025
638df4b
Adding git ignore for agent0 output
Jan 9, 2025
23b7978
Removing unused imports and using option field in burn
Jan 9, 2025
54f7669
Adding fixme comment
Jan 9, 2025
0b1df87
Another fixme comment
Jan 9, 2025
1420bfa
Adding readme to python fuzzing
Jan 9, 2025
76af955
Pointing agent0 req to pypi
Jan 9, 2025
1fecbc1
Committed incremental progress
jalextowle Jan 10, 2025
324beb3
Added more `mint` and `burn` related cases to the `InstanceTest` suite
jalextowle Jan 11, 2025
cf64c36
Fixed the failing `test_burn_with_base` tests
jalextowle Jan 16, 2025
07afed0
Added another instance test and got all of the tests working
jalextowle Jan 16, 2025
85833a7
Uncommented and fixed another test
jalextowle Jan 17, 2025
e6fc7f1
Uncommented the remaining test
jalextowle Jan 17, 2025
e70d1fb
Fixed the code size issue
jalextowle Jan 18, 2025
4e179a5
Removed fixmes -- the investigation showed that the calculations work…
jalextowle Jan 18, 2025
75c561a
Fixed some of the CI jobs
jalextowle Jan 18, 2025
464eb41
Fixed the LPWithdrawal tests
jalextowle Jan 21, 2025
9941acb
Attempted to fix the code coverage job
jalextowle Jan 22, 2025
eda8416
Removed the code coverage badge
jalextowle Jan 22, 2025
c2a1805
Fuzzing notes
jalextowle Jan 10, 2025
78cb0cf
Got a working prototype of the `mint` and `burn` fuzzing working
jalextowle Jan 22, 2025
b85c98d
Added the `burn` route to the fuzz bots
jalextowle Jan 23, 2025
52fd877
Updated remaining FIXMEs
jalextowle Jan 24, 2025
54311c4
Merge remote-tracking branch 'origin/main' into slundquist/mintfuzz
jalextowle Jan 24, 2025
3b8f249
Removed newlines
jalextowle Jan 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Committed incremental progress
  • Loading branch information
jalextowle committed Jan 23, 2025
commit 1fecbc1a1874ebe670eacc9564313728a1c1181f
4 changes: 2 additions & 2 deletions contracts/src/internal/HyperdrivePair.sol
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,10 @@ abstract contract HyperdrivePair is IHyperdriveEvents, HyperdriveLP {
// 2 * bondAmount * flatFee * governanceFee
// )
//
// This implies that
// This implies that:
//
// bondAmount = shareDeposited * vaultSharePrice / (
// 1 + (max(c, c0) - c0) / c0 + flatFee + 2 * flatFee * governanceFee
// max(c, c0) / c0 + flatFee + 2 * flatFee * governanceFee
// )
//
// NOTE: We round down to underestimate the bond amount.
Expand Down
2 changes: 1 addition & 1 deletion test/instances/ezETH/EzETHHyperdrive.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ contract EzETHHyperdriveTest is InstanceTest {
roundTripShortInstantaneousWithSharesTolerance: 1e7,
roundTripShortMaturityWithSharesTolerance: 1e8,
// The verification tolerances.
verifyDepositTolerance: 2,
verifyDepositTolerance: 300,
verifyWithdrawalTolerance: 1_000
})
)
Expand Down
Loading