Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mint fuzzing #1236

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Mint fuzzing #1236

wants to merge 46 commits into from

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Jan 9, 2025

This PR drafts the scaffolding for using agent0 to fuzz mint/burn. There are currently FIXME comments in the script detailing the necessary changes needed to (1) detail conditions where an agent can call mint and burn, (2) specifying the right parameters to mint and burn, and (3) specifying where any additional invariance checks associated with mint and burn would go in the script.

jalextowle and others added 17 commits January 7, 2025 17:45
@jalextowle
Adds an openPair function
66edc7f
@jalextowle
Removes some outdated comments
2614a15
@jalextowle
Added governance fees to the mint function
8a557f6
@jalextowle
Updated the implementation of HyperdrivePair
4f75460
@jalextowle
Updated the mint logic and wired it up
c96d744
@jalextowle
Added unit test cases for the mint function
be28b36
@jalextowle
Adds comprehensive unit tests for the mint function
94a124a
@jalextowle
Adds a minOutput parameter to mint
75bd986
@jalextowle
Wrote a comprehensive integration test suite for the mint function
7817f25
@jalextowle
Started implementing burn
1daa62f
@jalextowle
Made some targeted fixes to mint
f3c1627
@jalextowle
Added zombie interest to the burn flow and cleaned up HyperdrivePair
886ad43
@jalextowle
Started adding a test suite for the burn function
e748cf9
@jalextowle
Added the remaining test cases. Some of them are broken.
788ea8b
@jalextowle
Fixed the remaining burn unit tests
22a3871
@jalextowle
Added an integration test suite for burn
39b5573
@slundqui
Bumping solidity version of mint to match rest of repo (#1235)
9399732
@slundqui slundqui marked this pull request as draft January 9, 2025 19:21
@slundqui slundqui force-pushed the slundquist/mintfuzz branch from f05671c to 76af955 Compare January 10, 2025 18:25
Base automatically changed from jalextowle/feature/mint to main January 23, 2025 22:08
@jalextowle
Committed incremental progress
1fecbc1
@jalextowle
Added more mint and burn related cases to the InstanceTest suite
324beb3
@jalextowle
Fixed the failing test_burn_with_base tests
cf64c36
@jalextowle
Added another instance test and got all of the tests working
07afed0
@jalextowle
Uncommented and fixed another test
85833a7
@jalextowle
Uncommented the remaining test
e6fc7f1
@jalextowle
Fixed the code size issue
e70d1fb
@jalextowle
Removed fixmes -- the investigation showed that the calculations work…
4e179a5 
…ed correctly
@jalextowle
Fixed some of the CI jobs
75c561a
@jalextowle
Fixed the LPWithdrawal tests
464eb41
@jalextowle
Attempted to fix the code coverage job
9941acb
@jalextowle
Removed the code coverage badge
eda8416
@jalextowle
Fuzzing notes
c2a1805
@jalextowle
Got a working prototype of the mint and burn fuzzing working
78cb0cf
@jalextowle
Added the burn route to the fuzz bots
b85c98d
@jalextowle
Updated remaining FIXMEs
52fd877
@jalextowle
Merge remote-tracking branch 'origin/main' into slundquist/mintfuzz
54311c4
@jalextowle jalextowle marked this pull request as ready for review January 24, 2025 23:32
@jalextowle jalextowle enabled auto-merge January 24, 2025 23:33
@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12959388001

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.489%
Totals Coverage Status
Change from base Build 12941312920: 0.0%
Covered Lines: 3014
Relevant Lines: 3368
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2025 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: 3b8f249 Previous: 3497650 Deviation Status
addLiquidity: min 33899 gas 33899 gas 0% 🟰
addLiquidity: avg 203753 gas 203380 gas 0.1834% 🚨
addLiquidity: max 187737 gas 191291 gas -1.8579% ✅
burn: min 31493 gas 31493 gas 0% 🟰
burn: avg 135675 gas 136107 gas -0.3174% ✅
burn: max 111180 gas 111180 gas 0% 🟰
checkpoint: min 40289 gas 40289 gas 0% 🟰
checkpoint: avg 148341 gas 148356 gas -0.0101% ✅
checkpoint: max 149219 gas 149219 gas 0% 🟰
closeLong: min 31481 gas 31481 gas 0% 🟰
closeLong: avg 146568 gas 146214 gas 0.2421% 🚨
closeLong: max 126677 gas 126689 gas -0.0095% ✅
closeShort: min 31336 gas 31336 gas 0% 🟰
closeShort: avg 137725 gas 137443 gas 0.2052% 🚨
closeShort: max 132851 gas 132580 gas 0.2044% 🚨
initialize: min 31313 gas 31313 gas 0% 🟰
initialize: avg 355316 gas 355025 gas 0.0820% 🚨
initialize: max 355601 gas 355601 gas 0% 🟰
openLong: min 33330 gas 33330 gas 0% 🟰
openLong: avg 179004 gas 179602 gas -0.3330% ✅
openLong: max 191362 gas 191434 gas -0.0376% ✅
openShort: min 33896 gas 33896 gas 0% 🟰
openShort: avg 180785 gas 180333 gas 0.2506% 🚨
openShort: max 170068 gas 170068 gas 0% 🟰
redeemWithdrawalShares: min 31259 gas 31259 gas 0% 🟰
redeemWithdrawalShares: avg 77193 gas 77780 gas -0.7547% ✅
redeemWithdrawalShares: max 67460 gas 67460 gas 0% 🟰
removeLiquidity: min 31265 gas 31265 gas 0% 🟰
removeLiquidity: avg 214582 gas 214089 gas 0.2303% 🚨
removeLiquidity: max 220575 gas 218337 gas 1.0250% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle added this pull request to the merge queue Jan 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalextowle jalextowle jalextowle approved these changes

@jrhea jrhea Awaiting requested review from jrhea jrhea is a code owner

@mcclurejt mcclurejt Awaiting requested review from mcclurejt

@dpaiton dpaiton Awaiting requested review from dpaiton

@Sean329 Sean329 Awaiting requested review from Sean329 Sean329 is a code owner

@cashd cashd Awaiting requested review from cashd cashd is a code owner

@sentilesdal sentilesdal Awaiting requested review from sentilesdal sentilesdal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slundqui @coveralls @jalextowle