Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Vitest implementation #267

Merged
merged 9 commits into from
Jul 24, 2023
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export const supportedChainIds = [42069, 31337] as const;

export type SupportedChainId = (typeof supportedChainIds)[number];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but when I pulled main this file was updated. Do we need the parens here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not if it builds without em 👍

export type SupportedChainId = typeof supportedChainIds[number];
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
"dev": "turbo run dev --parallel --filter=./apps/*",
"lint": "turbo run lint",
"lint:packages": "turbo run lint --filter=./packages/*",
"test": "yarn workspace @hyperdrive/core run test",
"test:run": "yarn workspace @hyperdrive/core run test:run",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: top-level package.json shouldn't include any specific project scripts. Let's add just add the test script, and run it the same way as other scripts here, ie: turbo run test

"format": "turbo run format",
"format:check": "turbo run format:check",
"postinstall": "husky install"
Expand Down
4 changes: 3 additions & 1 deletion packages/hyperdrive/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
},
"scripts": {
"watch": "parcel watch",
"build": "parcel build --no-cache"
"build": "parcel build --no-cache",
"test": "vitest",
"test:run": "vitest run"
},
"devDependencies": {
"@hyperdrive/eslint-config": "*",
Expand Down
29 changes: 29 additions & 0 deletions packages/hyperdrive/src/test/multiplyBigInt.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { multiplyBigInt } from "src/base/multiplyBigInt";
import { test, assert } from "vitest";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Curious why we're using assert vs expect for assertions. I couldn't find any vitest docs about assert, but there's a whole page for how to use expect. Did I miss something?

https://vitest.dev/api/expect.html#expect-assertions


test("multiplyBigInt: simple multiplication", async () => {
const result = multiplyBigInt([500n, 50n], 2);
assert.equal(result, 250n, "5.00 * 0.50 should equal 2.50");
});

test("multiplyBigInt: when values array is empty", async () => {
const result = multiplyBigInt([], 2);
assert.equal(result, 0n, "Multiplying empty array should return 0");
});

test("multiplyBigInt: single value input", async () => {
const result = multiplyBigInt([10n], 2);
assert.equal(result, 10n, "Single value should be returned as-is");
});

test("multiplyBigInt: multiplying with zero", async () => {
const result = multiplyBigInt([500n, 0n], 2);
assert.equal(result, 0n, "Any value multiplied by 0 should be 0");
});

test("multiplyBigInt: multiplying multiple bigint values", async () => {
// Test case: multiplying three values
// Let's say our values are [2000n, 300n, 50n] and for 2 decimals, this translates to 20.00 * 3.00 * 0.50 = 30.00
const result = multiplyBigInt([2000n, 300n, 50n], 2);
assert.equal(result, 3000n, "20.00 * 3.00 * 0.50 should equal 30.00");
});
12 changes: 12 additions & 0 deletions packages/hyperdrive/vite.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { defineConfig } from "vitest/config";
import type { UserConfig as VitestUserConfigInterface } from "vitest/config";

const vitestConfig: VitestUserConfigInterface = {
test: {
// https://vitest.dev/config
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup the test config so we can customize it when needed.

},
};

export default defineConfig({
test: vitestConfig.test,
});