Basic Vitest implementation #267
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -1,3 +1,3 @@ | |||
| export const supportedChainIds = [42069, 31337] as const; | |||
|
|
|||
| export type SupportedChainId = (typeof supportedChainIds)[number]; | |||
There was a problem hiding this comment.
Not related to this PR, but when I pulled main this file was updated. Do we need the parens here?
There was a problem hiding this comment.
Not if it builds without em 👍
|
|
||
| const vitestConfig: VitestUserConfigInterface = { | ||
| test: { | ||
| // https://vitest.dev/config |
There was a problem hiding this comment.
Setup the test config so we can customize it when needed.
| @@ -1,3 +1,3 @@ | |||
| export const supportedChainIds = [42069, 31337] as const; | |||
|
|
|||
| export type SupportedChainId = (typeof supportedChainIds)[number]; | |||
There was a problem hiding this comment.
Not if it builds without em 👍
package.json
Outdated
| @@ -12,6 +12,8 @@ | |||
| "dev": "turbo run dev --parallel --filter=./apps/*", | |||
| "lint": "turbo run lint", | |||
| "lint:packages": "turbo run lint --filter=./packages/*", | |||
| "test": "yarn workspace @hyperdrive/core run test", | |||
| "test:run": "yarn workspace @hyperdrive/core run test:run", | |||
There was a problem hiding this comment.
minor: top-level package.json shouldn't include any specific project scripts. Let's add just add the test script, and run it the same way as other scripts here, ie: turbo run test
| @@ -0,0 +1,29 @@ | |||
| import { multiplyBigInt } from "src/base/multiplyBigInt"; | |||
| import { test, assert } from "vitest"; | |||
There was a problem hiding this comment.
minor: Curious why we're using assert vs expect for assertions. I couldn't find any vitest docs about assert, but there's a whole page for how to use expect. Did I miss something?
|
Fixed based on the comments above. Should be able to just run |
This PR implements a basic testing suite using Vitest. I wrote the first test for multiplying bigints
